-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing the trailing inserter in favor of a clickable area #3078
Comments
This seems a solid idea. I keep thinking that the "on editor canvas" If we have a reliable method to add on the toolbar and a single fast method with the cursor (and typing) I think it's more than enough. |
That looks very interesting! I think we should have a predefined outline around an area we can call the canvas or document. This area one can click into this area and just begin writing. It should be easy to just write and adjust the writing with easily available text options. I made this issue: #3539 which is somewhat similar. |
Of course this should be done in an accessible way. What the "clickable area" would be in terms of semantic HTML? How that would be announced by assistive technologies? How that would work when using only the keyboard? Worth reminding any UI control should be properly labeled, whether it's a textarea, an input field, an editable block, a button, etc. Ideally, labels should be visible. If there's a strong design need to hide the labels, a possible trade-off would be hiding them visually with screen-reader-text or similar CSS technique. |
So, we had this merged in, and then reverted again due to some keyboard troubles, and suggestions to resurface the trailing inserter. Here are mockups for addressing the latter. 1, you hover near the end: 2, you click that spot, and get a textarea to type in, and a clickable inserter on the left. 3, if you start typing, it's business as usual: 3b, Otherwise, you can click the inserter on the left, which is also mostly business as usual The big difference is that the trailing inserter is not visible until you've put focus in the trailing placeholder. Thoughts? |
May I ask a short tl;dr summary of what were the issues that made us to revert? Just to understand and give more grounded feedback. That said, this direction seems a good one to explore: simple, reusing all our elements. :) |
The details start here, but the summary is:
|
Closing as this is now a thing. |
Nice! The above approach seems to create a much better text writing flow. |
Right now we have a trailing inserter that lets you insert content at the end. There are also hover buttons to the right of this. This is working reasonably well, but it is also a design that was created before we had a slash command, and before we had the "insert between" shortcut. As it stands, this gives us 4 ways to insert content — from the toolbar, in between, using the slash command, and at the end.
In most content editors, clicking below all the content simply sets focus there, which lets you either insert new content, or start typing. Perhaps with recent advances in insertion by other means, we can retire this interface?
It could look like this:
Just click at the end of the post — the white area below — and you'd be in a paragraph where you could type, or use the slash command. There would be no placeholder text like we've tried in the past, doesn't even have to be a special cursor.
We'd probably want to combine this feature with a change to how the inserter works when focus is in an empty paragraph. That is, it should work like the slash command inserter does, and replace the empty text block.
Thoughts?
The text was updated successfully, but these errors were encountered: