Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation editor: it shouldn't be possible to add a menu to itself #30745

Closed
javierarce opened this issue Apr 12, 2021 · 1 comment · Fixed by #34568
Closed

Navigation editor: it shouldn't be possible to add a menu to itself #30745

javierarce opened this issue Apr 12, 2021 · 1 comment · Fixed by #34568
Labels
[Type] Bug An existing feature does not function as intended

Comments

@javierarce
Copy link
Contributor

Currently, it's possible to create a menu and add it to itself when selecting the menu from the "Existing menus" dropdown.

I think this could be a minor bug since the backend seems to ignore the recursion, returns a 200 status, and the menu doesn't get broken.

Step-by-step reproduction instructions

  1. Create a menu using the Navigation (beta) option in Gutenberg.
  2. Click on the placeholder.
  3. Click on the "Existing menu" dropdown.

Expected behaviour

If the user has several menus, the name of the current one shouldn't appear on the list. If this is the first menu, the dropdown shouldn't appear or at least it shouldn't contain the current menu as an option.

Actual behaviour

The list contains the name of the current menu.

Screenshots or screen recording (optional)

Screen.Recording.2021-04-12.at.15.01.10.mov

WordPress information

WordPress version: 5.7
Gutenberg version: 10.3.2
Are all plugins except Gutenberg deactivated? Yes

@priethor priethor added [Feature] Navigation Screen [Type] Bug An existing feature does not function as intended labels Apr 12, 2021
@getdave
Copy link
Contributor

getdave commented May 5, 2021

This seems like something that needs to be fixed. Thanks @javierarce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants