Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: theme data for Global Styles and Templates #30191

Closed
vindl opened this issue Mar 24, 2021 · 2 comments
Closed

FSE: theme data for Global Styles and Templates #30191

vindl opened this issue Mar 24, 2021 · 2 comments
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Question Questions about the design or development of the editor.

Comments

@vindl
Copy link
Member

vindl commented Mar 24, 2021

We are storing templates and template parts in wp_template and wp_template_parts CPTs respectively. In order to associate them with their corresponding themes, we added wp_theme taxonomy in which the theme stylesheet is saved for each post. (ref)

For storing Global Styles data, we similarly have global_styles CPT, but the corresponding theme info is saved in the post name (wp-global-styles-<theme-stylesheet>). (ref)

Would it make sense to align these approaches for consistency?

cc @nosolosw @mtias @youknowriad

@vindl vindl added [Type] Question Questions about the design or development of the editor. [Feature] Full Site Editing Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Mar 24, 2021
@oandregal oandregal mentioned this issue Mar 24, 2021
82 tasks
@oandregal
Copy link
Member

I've added this to the list of things to do for 5.8 at #20331 (see 3rd wave, theme.json group).

@oandregal
Copy link
Member

This has been closed by #31436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

3 participants