Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Sub menu items do not adopt template part color changes #30165

Closed
annezazu opened this issue Mar 24, 2021 · 6 comments
Closed
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

If you add the navigation block to a template part and change the template part colors, the sub menu items do not adjust in the same way the overall navigation block does. @carolinan not quite sure if this is possibly a TT1 blocks problem or not!

Step-by-step reproduction instructions

  1. Add a template part
  2. Add a navigation block inside template part
  3. Add a few menu items including some sub menu items
  4. Change the colors of the template part text and background.
  5. Notice the sub menu items do not change color.

Expected behaviour

I expect the sub menu items to match the changes I made to the template colors.

Actual behaviour

The sub menu items remain at their default state.

Screenshots or screen recording (optional)

Editor view:

Screen Shot 2021-03-23 at 7 04 09 PM

Front end view:
Screen Shot 2021-03-23 at 7 07 24 PM

WordPress information

  • WordPress version: 5.7
  • Gutenberg version: 10.2.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? TT1 Blocks

Device information

  • Device: Desktop
  • Operating system: MacOS
  • Browser: Chrome 88
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Mar 24, 2021
@carolinan
Copy link
Contributor

Sub menus are not transparent, they have a white background by default and do not "inherit" the parent block background color.
If they were transparent the menu item would not be readable when it overlapped other content.

Changing the navigation block background color will change the sub menu background color.

@jasmussen
Copy link
Contributor

Carolina explains it well.

I have this ticket that might serve as a solution: #29963

@annezazu
Copy link
Contributor Author

Heh yes! Apologies. I was opening one too many issues yesterday. Transparent wasn't the right word. I saw that ticket as well!

Should this be closed? It's unclear to me what's expected but the current experience is a bit frustrating regardless.

@jasmussen
Copy link
Contributor

Should this be closed?

The same PR will fix both tickets. But this one perhaps has better SEO :) So it has value for people searching. But that may be the case whether open or closed.

@carolinan
Copy link
Contributor

Hi, can this be closed?

@annezazu
Copy link
Contributor Author

annezazu commented Jan 5, 2022

Looks like it :) Closing.

@annezazu annezazu closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants