Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: Move support for the <!--more--> tag out of the parser #2973

Closed
pento opened this issue Oct 11, 2017 · 2 comments · Fixed by #5061
Closed

Parser: Move support for the <!--more--> tag out of the parser #2973

pento opened this issue Oct 11, 2017 · 2 comments · Fixed by #5061
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@pento
Copy link
Member

pento commented Oct 11, 2017

<!--more--> (and its cousin, <!--noteaser-->) are currently handled as special cases in the parser.

To keep the parser Gutenberg-focussed, these should be moved to the legacy paste handler, where they can be transformed into a <!-- wp:more --> block.
@pento pento added the [Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f label Oct 11, 2017
@pento pento mentioned this issue Oct 11, 2017
Merged
@mtias
Copy link
Member

mtias commented Oct 11, 2017 •
edited
Loading

The noteaser can become an attribute of wp:more, which makes a lot more sense as well.

@mtias mtias added the [Feature] Blocks Overall functionality of blocks label Oct 11, 2017
@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jan 4, 2018
@mtias mtias mentioned this issue Feb 7, 2018
Closed
@mcsf mcsf mentioned this issue Feb 13, 2018
Merged
3 tasks
@mcsf
Copy link
Contributor

mcsf commented Feb 14, 2018 •
edited
Loading

Will open a PR tomorrow, but here’s a working branch:
https://github.com/WordPress/gutenberg/compare/remove/parser-more-and-noteaser-exception?expand=1

—> #5061

@mcsf mcsf mentioned this issue Feb 14, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parser: Remove specific support for <!--more--> tag WordPress/gutenberg
3 participants
@mcsf @pento @mtias