Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: template management #29449

Closed
5 tasks
vindl opened this issue Mar 1, 2021 · 2 comments
Closed
5 tasks

Site Editor: template management #29449

vindl opened this issue Mar 1, 2021 · 2 comments
Labels
Needs Decision Needs a decision to be actionable or relevant Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts.

Comments

@vindl
Copy link
Member

vindl commented Mar 1, 2021

Currently in the Site Editor we can only insert templates from a predefined list, provided that they are not already included in the theme:

Screenshot 2021-03-01 at 22 36 49

This leaves a couple of missing options. We should consider whether it would make sense to add some of the following functionalities:

  • Delete existing templates
    • Deleting user created templates - this amounts to deleting the corresponding CPT
    • Deleting theme provided templates - we probably don't want to delete the actual files, since that won't persist through theme updates. Instead we can mark these templates as deleted and use that to skip them in template resolution
  • Change the currently assigned template for the page
  • Create a new template that's targeting a specific page (page-{ID}.php or page-{slug}.php equivalent). We can consider allowing the creation of arbitrarily named (unassigned) templates, but it's not clear whether that will be necessary in addition to the previous flow
@vindl vindl added Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. Needs Decision Needs a decision to be actionable or relevant [Feature] Full Site Editing labels Mar 1, 2021
@mtias
Copy link
Member

mtias commented Mar 2, 2021

I hope we could explore a more focused modal flow for the "create new template" where we can afford more room to explain things, and could show the templates that already exist next to the missing ones.

@Addison-Stavlo
Copy link
Contributor

im going to close this issue as stale as the interface has been redone and includes a lot of the requested tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Decision Needs a decision to be actionable or relevant Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

3 participants