Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: block sibling inserter is positioned incorrectly #28885

Closed
vindl opened this issue Feb 9, 2021 · 5 comments
Closed

Site Editor: block sibling inserter is positioned incorrectly #28885

vindl opened this issue Feb 9, 2021 · 5 comments
Assignees
@david-szabo97
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@vindl
Copy link
Member

vindl commented Feb 9, 2021

We recently introduced an experiment for a less prominent sibling inserter in #28550. It works fine in the post editor, but for some reason it's broken in the site editor. This makes it impossible to use it in horizontal case.

Screenshot 2021-02-09 at 16 29 02

Screenshot 2021-02-09 at 16 29 33
@vindl vindl added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention [Feature] Full Site Editing labels Feb 9, 2021
@vindl vindl mentioned this issue Feb 9, 2021
Merged
6 tasks
@vindl
Copy link
Member Author

vindl commented Feb 9, 2021

There is an open PR that resolves this #28630.

@jasmussen
Copy link
Contributor

Was about to say that this appears a duplicate of #28457

@vindl
Copy link
Member Author

vindl commented Feb 9, 2021

Was about to say that this appears a duplicate of #28457

That one seemed related just to column block and with different positioning offset, while this one applies to all blocks. Fortunately the linked PR solves both issues.

@david-szabo97
Copy link
Member

We can close #28457 in favor of this one. But hopefully, we can merge soon and get both ticked off. My PR was more specific but it's basically the same issue, the same component that's causing it.

@david-szabo97
Copy link
Member

Fixed by #28630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-szabo97 david-szabo97

Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vindl @jasmussen @david-szabo97