Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down arrow should not be rendered on SelectControl when multiple = false #28818

Closed
JohnRDOrazio opened this issue Feb 7, 2021 · 2 comments
Closed
Labels
[Feature] UI Components Impacts or related to the UI component system [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@JohnRDOrazio
Copy link
Contributor

Description

A down arrow / chevron is rendered on all SelectControl components, whether or not the multiple property / attribute is set to true. It should not be needed when multiple:true because there is no dropdown in this case.

Step-by-step reproduction instructions

Create a SelectControl component, and set the multiple property to true.

Expected behaviour

No down arrow should be rendered.

Actual behaviour

A down arrow is rendered.

Screenshots or screen recording (optional)

Code snippet (optional)

WordPress information

  • WordPress version: 5.6.1
  • Gutenberg version: 9.9.0
  • Are all plugins except Gutenberg deactivated? No
  • Are you using a default theme (e.g. Twenty Twenty-One)? No

Device information

  • Device:
  • Operating system:
  • Browser:

I created PR #28817 to fix this. (not tested, needs review and testing)

@talldan talldan added [Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended labels Feb 8, 2021
@talldan
Copy link
Contributor

talldan commented Feb 8, 2021

This is easy to reproduce in the storybook - https://wordpress.github.io/gutenberg/?path=/story/components-selectcontrol--default.

@talldan
Copy link
Contributor

talldan commented Apr 12, 2021

I see this is already tracked in #27166, so will consolidate the issues by closing this as a duplicate.

@talldan talldan closed this as completed Apr 12, 2021
@talldan talldan added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants