Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned items should remember their place, at least the Settings sidebar should #28546

Closed
jasmussen opened this issue Jan 28, 2021 · 1 comment · Fixed by #29287
Closed

Pinned items should remember their place, at least the Settings sidebar should #28546

jasmussen opened this issue Jan 28, 2021 · 1 comment · Fixed by #29287
Assignees
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jasmussen
Copy link
Contributor

#28526 fixed an issue where plugins that add a sidebar and pin items to the toolbar would show up on mobile. That was a regression from a past behavior where it was decided that pinned items are only accessible from the More menu on mobile (see also #14457).

While the issue is fixed, the solution isn't solid. If you unpin a plugin sidebar, then pin it again, it's now the first pinned item, which is problematic as the Settings cog should always be the first icon:

106005578-a4c9cb00-60b4-11eb-98c6-bd731ce38582

The fact that upon a page reload, the pinned item is back where it "should" be, suggests it's a bug.

There are some thoughts to ponder as far as solutions go:

Both of those use cases need to be considered when finding a good solution.

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Feature] Extensibility The ability to extend blocks or the editing experience labels Jan 28, 2021
@ridesirat
Copy link

Hi guys
sorry, I know it's not exactly related but you decide where it's best.
I think the order of this is RTL, so, shouldn't the "Preview + Publish + Cog" be always on the right?
It's a reflexive thing, go to the right to Publish, etc.
For the pin, there could be an icon (star? :) for pinned items and a way to reorder them by user choice. That way, as the screen size changes, the preferred ones will always be visible until they all collapse to the pin icon.
When you press the icon, a drop down (Google style) with all of them appears. Or a right bar (Adobe style).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants