Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select navigation block if first clicking canvas #28166

Closed
jasmussen opened this issue Jan 13, 2021 · 6 comments · Fixed by #29892
Closed

Can't select navigation block if first clicking canvas #28166

jasmussen opened this issue Jan 13, 2021 · 6 comments · Fixed by #29892
Assignees
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jasmussen
Copy link
Contributor

Steps to reproduce:

  1. Insert a navigation block. Vertical or horizontal, doesn't matter.
  2. Click "Start Empty".
  3. Click outside the editing canvas, for example to the right of post content, to deselect all blocks.
  4. Click the navigation block to select it.

Observe that the navigation block receives focus (as indicated by the blue border), but is not selected. So neither the block toolbar appears, or the is-selected CSS class is present.

Note that if instead of clicking outside the editing canvas, you select a different block, you can select the navigation block.

I wasn't able to reproduce this issue with any other blocks than Navigation, it doesn't seem like this would be limited to just this block. But it does appear to be related to nesting.

GIF showing the above:

Jan-12-2021 13-11-43

Chatted yesterday with @gziolo, @ellatrix and @retrofox, and it was suggested that AsyncModeProvider could theoretically be related to the cause of the issue. It's the cause of this adjacent Safari-only bug: #19454.

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jan 13, 2021
@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Jan 13, 2021
@ZebulanStanphill
Copy link
Member

I recently ran into a very similar (if not the same) issue after rebasing #21234: my Table of Contents block PR. Notably, both blocks use <nav>, <ul>, and <li> elements, so maybe that's related somehow?

@jasmussen
Copy link
Contributor Author

I had the same thought, and in a shotgun debugging session, I tried replacing all those with divs. Alas, no change.

@ntsekouras
Copy link
Contributor

@jasmussen I couldn't reproduce this. Is this still happening?

@jasmussen
Copy link
Contributor Author

Hallelujah, no, it appears fixed!

@jasmussen
Copy link
Contributor Author

Ack, I'm seeing it again. Reopening. Same steps to reproduce.

@jasmussen jasmussen reopened this Mar 2, 2021
@jasmussen
Copy link
Contributor Author

This one is potentially related: #29678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
6 participants