Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-between Inserter is Unreliable #28123

Closed
shaunandrews opened this issue Jan 12, 2021 · 4 comments · Fixed by #32576
Closed

In-between Inserter is Unreliable #28123

shaunandrews opened this issue Jan 12, 2021 · 4 comments · Fixed by #32576
Assignees
@talldan
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@shaunandrews
Copy link
Contributor

Inbetween Inserter

I can get the in-between inserter to appear between widget areas, which seems like a mistake.

Also, unless there are multiple widgets in a sidebar area, I'm unable to get the in-between inserter to appear.
@shaunandrews shaunandrews added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Jan 12, 2021
@kevin940726 kevin940726 mentioned this issue Jan 14, 2021
Merged
6 tasks
@draganescu
Copy link
Contributor

That inserter should not be visible as we cannot insert a new widget area, these are defined by themes.

widgets-weird-inserter

@draganescu draganescu changed the title Widgets: In-between Inserter is Unreliable In-between Inserter is Unreliable Feb 18, 2021
@draganescu draganescu mentioned this issue Feb 18, 2021
Closed
53 tasks
@talldan
Copy link
Contributor

talldan commented Apr 12, 2021

Yeah, I think the template should be locked down for widget areas, so the bug might be that the indicator is displaying in locked template areas.

@ellatrix ellatrix self-assigned this May 21, 2021
@noisysocks
Copy link
Member

@ellatrix: Are you working on this?

@talldan talldan self-assigned this Jun 10, 2021
@talldan talldan mentioned this issue Jun 10, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 10, 2021
@talldan
Copy link
Contributor

talldan commented Jun 10, 2021

#32576 should fix the issue in locked widget areas, and I saw there's #31896 that covers everything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix insertion point displaying when there are no inserter items WordPress/gutenberg
5 participants
@draganescu @shaunandrews @noisysocks @talldan @ellatrix