Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE Single - Multi-selection of paragraphs loses the toolbar #279

Closed
mapk opened this issue Mar 15, 2017 · 8 comments
Closed

TinyMCE Single - Multi-selection of paragraphs loses the toolbar #279

mapk opened this issue Mar 15, 2017 · 8 comments

Comments

@mapk
Copy link
Contributor

mapk commented Mar 15, 2017

When selecting multiple parargaphs, the toolbar disappears. This doesn't feel right to me.

lost-toolbar

Shouldn't I be able to apply bold, or italic, or whatever to multiple text selections at one time?

@ellatrix
Copy link
Member

Yeah, this is a to-do. Also wonder what control should be added there. Not sure if people should really apply inline formatting across blocks... What could make sense here is blockquote, lists, preformatted... What do you think?

@ellatrix
Copy link
Member

Also still need to make drag and drop work for multiple selection.

@mapk
Copy link
Contributor Author

mapk commented Mar 15, 2017

Well ideally, it should act just like it does when I'm highlighting a single block. In the example above, the toolbar should remain the same b/c they're both paragraph blocks. When it comes to highlighting different block types, then I'm not too sure how that would work. Maybe the same?

@jasmussen
Copy link
Contributor

I tend to agree that whenever a block is selected, all formatting controls for that block should be visible until you select something else, like a caption, or another block.

Blockquotes and lists are the tricky ones. The pattern that people are used to is: select a lot, the click list/blockquote as a formatting button. One of the aspects of this block-first UI experiment, though, is that we show block level type selection in the switcher, not as part of the block alignments bar, and not as part of inline formatting either. In that way it'd be just like how you make multiple paragraphs into preformatted text in the current editor.

I think that's what we should try for now, even if I have a hunch it's not going to be as user-friendly. Then we can test it, see if it works for people, and if it doesn't, we'll cross that bridge. A button is a fine plan B.

#testreminder 👈 let's use this tag in github and slack as something we can write down on things we want to be part of usertests. Then it's easier to search for when we put together instructions.

@jasmussen
Copy link
Contributor

See also #62

@mtias
Copy link
Member

mtias commented Mar 17, 2017

My take is that whenever you select across blocks you let go of the notion of block, so anything block specific should be removed. The main action for selecting across block should be to delete or cut/copy. This applies to both prototypes.

@joyously
Copy link

My take is that whenever you select across blocks you let go of the notion of block, so anything block specific should be removed. The main action for selecting across block should be to delete or cut/copy. This applies to both prototypes.

I agree with letting go of the block context, but I don't agree with the main actions. Especially for text, how often do you type a few paragraphs and then want to delete or cut/copy? I suggest that main actions would be formatting such as float right, or centered text, or bigger font, or group into a box with a border and background.

@jasmussen
Copy link
Contributor

As this was related to the prototype and we're working on the plugin now, I'm closing this in favor of #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants