Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show the Global Styles sidebar in edit site if theme doesn't support theme.json #27394

Open
oandregal opened this issue Dec 1, 2020 · 4 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

Steps to reproduce the bug:

  • Activate a FSE theme that doesn't have a theme.json
  • Go to the edit site.

The expected behavior is that the "Global Styles" sidebar shouldn't be shown, as the theme hasn't declared support.

@oandregal oandregal added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 1, 2020
@oandregal oandregal mentioned this issue Dec 1, 2020
82 tasks
@youknowriad
Copy link
Contributor

theme.json is not just about global styles. What happens if I use a theme.json to enable/disable some features in the editor but maybe I still don't want the global styles sidebar?

@oandregal
Copy link
Member Author

Depending on where we land at #27295 (comment) the exact checks we need for this may vary. Probably it's worth investigating this issue after 27295 is tackled.

@skorasaurus
Copy link
Member

Is this still an issue ?

@ramonjd
Copy link
Member

ramonjd commented Apr 8, 2024

I think this issue is still relevant. See discussion on #52750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants