Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Block Categories #2727

Closed
ahmadawais opened this issue Sep 13, 2017 · 8 comments
Closed

Extending Block Categories #2727

ahmadawais opened this issue Sep 13, 2017 · 8 comments

Comments

@ahmadawais
Copy link
Contributor

While registering a new block, I can only assign the default categories formatting | layout | widgets | embeds. What I would like to do is extend the categories. I can't seem to find a way to do that. I think there should be an API to register new categories as well.

Looking forward!

@kuoko
Copy link
Contributor

kuoko commented Sep 15, 2017

Hi @ahmadawais,
Actually, there is already a conversation about that.

Here you can find my pull request #1732 waiting for a review.

Any feedback is highly appreciated.

@ahmadawais
Copy link
Contributor Author

ahmadawais commented Sep 15, 2017

@kuoko That's great. I just reviewed it. Not sure how I can contribute to it (guess you have to allow access), but I added comments.

@kuoko
Copy link
Contributor

kuoko commented Sep 18, 2017

Thanks @ahmadawais. I've updated the PR #1732 following your suggestions.
Don't know why you aren't able to contribute. The flag "allow edits from maintainers" is already checked.

@ahmadawais
Copy link
Contributor Author

I am only a contributor :)

@kuoko
Copy link
Contributor

kuoko commented Sep 19, 2017

Oh I see. me too.
Anyway, your advices were very helpful.
Thanks @ahmadawais

@karmatosed
Copy link
Member

Going to close this as looks like the other ticket has this being dealt with, no need to duplicate.

@ahmadawais
Copy link
Contributor Author

@karmatosed which other ticket? The PR? I suppose?

@karmatosed
Copy link
Member

The PR which was inspired by #1352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants