-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class Name with editor-font-sizes not working #26940
Comments
Testing with WordPress 5.7. I added into the functions file in the add_theme_support array section:
Frontend showed: |
It looks like we also allow upper and lowercase slug values that will collide with one another on the frontend class:
In general it looks like we break on a numerical value: If folks do take this one on, let's be careful to not break existing classnames for folks who might be depending on this. |
Thanks for the report @leadclown Going to consolidate this into #32347 as the issue is a bit larger than numbers (also affects camelCased slugs). |
There's a fix at #32352 |
when i use names like h1 or h2 as slug for add_theme_support(editor-font-sizes) i get the class name has-h-1-font-size in frontend not like expected has-h1-font-size.
h-1 as slug works fine and i get has-h-1-font-size but its ugly.
so i think the first one is much better for naming but bugged.
The text was updated successfully, but these errors were encountered: