Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing width from .wp-block-cover__inner-container may cause contents to shrink #26126

Closed
dreamwhisper opened this issue Oct 14, 2020 · 3 comments

Comments

@dreamwhisper
Copy link

dreamwhisper commented Oct 14, 2020

Describe the bug

Removing the calculated width from .wp-block-cover__inner-container as discussed here, can cause the contents of the container to change width compared to the original.

To reproduce
Steps to reproduce the behavior:

  1. Activate Twenty Nineteen with WP 5.5.1
  2. Add a full-width cover block.
  3. Inside the cover block, add a columns block and set it to 2 columns, then add a paragraph to each.
  4. Note the width of the block. It should match front end to editor.
  5. Update to 5.6-alpha or Gutenberg 9.9.1.
  6. Note the width of the content on the front end. It no longer matches the width in the editor. It also has shrunk compared to the original

Expected behavior
Width of content will not change when updating WordPress from 5.5.x to 5.6.

Screenshots

Original:

Screen Shot 2020-10-14 at 3 48 59 PM

New:

Screen Shot 2020-10-14 at 3 48 42 PM

Editor version (please complete the following information):

  • WordPress version: 5.6-alpha w/o Gutenberg
  • If the Gutenberg plugin is installed, which version is it? 9.9.1

Notes:

  • Doesn't impact Twenty Twenty because it sets a max width using [class*="__inner-container"].
@jasmussen
Copy link
Contributor

Thank you for the ticket. I believe #26143 fixes this one.

@talldan
Copy link
Contributor

talldan commented Oct 15, 2020

Closing as fixed by #26143

@talldan talldan closed this as completed Oct 15, 2020
@dreamwhisper
Copy link
Author

Thanks for the quick fix @jasmussen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants