Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlling the height of the Separator block #25989

Closed
paaljoachim opened this issue Oct 9, 2020 · 9 comments
Closed

Controlling the height of the Separator block #25989

paaljoachim opened this issue Oct 9, 2020 · 9 comments
Labels
[Block] Separator Affects the Separator Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Oct 9, 2020

Is your feature request related to a problem? Please describe.
Today we are not able to control the height of the Separator block.

Screen Shot 2020-10-09 at 13 36 54

Sometimes we might want the block to be shorter and other times taller. To have less or more space in the design.

Describe the solution you'd like
It would be helpful to duplicate the settings "height in pixels" from the Spacer block to the Separator block, so one can control the height. By controlling the height one would be able to create a greater flexibility in the design.

Here is an example from the Spacer block.

Screen Shot 2020-10-09 at 13 39 03

Describe alternatives you've considered
Using the Spacer block before/after the Separator block to give more space.
Spacer block
Separator block
Spacer block

Here is also an example from CoBlocks that @richtabor shared here:
#16483 (comment)

Associated overview issue: #16483

@paaljoachim paaljoachim added [Block] Separator Affects the Separator Block Needs Design Feedback Needs general design feedback. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Oct 9, 2020
@paaljoachim
Copy link
Contributor Author

The question comes up...
What if the user wants the line border close to the below content but wants more space above the line?

It could be possible to have two controls.
1 - Add space above border line.
2 - Add space below the border line.
This would control where the line is located in relation to the space added.

@richtabor
Copy link
Member

What if the user wants the line border close to the below content but wants more space above the line?

I feel like that could get quite messy. Perhaps something akin to the spacing/dimensions control?

@paaljoachim
Copy link
Contributor Author

Yeah. I agree. The extra control I mentioned with adding space above and below can be as you say messy. Keeping it simple would be helpful.

I am not sure what you mean when you say spacing/dimension control.

@simison
Copy link
Member

simison commented Nov 6, 2020

I had an old branch around for this so I just draft-PRed it: #26764

I won't have time in the near future to work on it but anyone feel free to take over! It's mostly there if I can remember right.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Nov 6, 2020

Thank you Mikael!

@richtabor
Would this be something for you to take over?

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 25, 2021
@stokesman
Copy link
Contributor

Perhaps something akin to the spacing/dimensions control?

I am not sure what you mean when you say spacing/dimension control.

That would be the approach taken in #28451 🔌

@carolinan carolinan removed Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress labels Jul 26, 2022
@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Oct 8, 2022
@tanjoymor
Copy link

Width and thickness controls, in addition to spacing above and below would be amazing, and super useful. The Separator and Dynamic blocks are super limited at the moment.

@stokesman
Copy link
Contributor

I wonder if this should be close given that margin support seems to be available as long as the theme has a theme.json and the support isn't disabled by said theme.json.

@paaljoachim
Copy link
Contributor Author

Yeah. As we now can add margin one can then also control the height. So I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Separator Affects the Separator Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback.
Projects
None yet
7 participants