-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controlling the height of the Separator block #25989
Comments
The question comes up... It could be possible to have two controls. |
I feel like that could get quite messy. Perhaps something akin to the spacing/dimensions control? |
Yeah. I agree. The extra control I mentioned with adding space above and below can be as you say messy. Keeping it simple would be helpful. I am not sure what you mean when you say spacing/dimension control. |
I had an old branch around for this so I just draft-PRed it: #26764 I won't have time in the near future to work on it but anyone feel free to take over! It's mostly there if I can remember right. |
Thank you Mikael! @richtabor |
That would be the approach taken in #28451 🔌 |
Width and thickness controls, in addition to spacing above and below would be amazing, and super useful. The Separator and Dynamic blocks are super limited at the moment. |
I wonder if this should be close given that margin support seems to be available as long as the theme has a theme.json and the support isn't disabled by said theme.json. |
Yeah. As we now can add margin one can then also control the height. So I will close this issue. |
Is your feature request related to a problem? Please describe.
Today we are not able to control the height of the Separator block.
Sometimes we might want the block to be shorter and other times taller. To have less or more space in the design.
Describe the solution you'd like
It would be helpful to duplicate the settings "height in pixels" from the Spacer block to the Separator block, so one can control the height. By controlling the height one would be able to create a greater flexibility in the design.
Here is an example from the Spacer block.
Describe alternatives you've considered
Using the Spacer block before/after the Separator block to give more space.
Spacer block
Separator block
Spacer block
Here is also an example from CoBlocks that @richtabor shared here:
#16483 (comment)
Associated overview issue: #16483
The text was updated successfully, but these errors were encountered: