Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Make Search block look nice when added to a Navigation #24643

Closed
noisysocks opened this issue Aug 19, 2020 · 5 comments · Fixed by #24666
Closed

Navigation: Make Search block look nice when added to a Navigation #24643

noisysocks opened this issue Aug 19, 2020 · 5 comments · Fixed by #24666
Labels
[Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field

Comments

@noisysocks
Copy link
Member

Here's how the Search block looks when added to a Navigation:

Screen Shot 2020-08-19 at 11 57 35

And here's the frontend:

Screen Shot 2020-08-19 at 11 58 09

When added to a Navigation, we should give Search a simpler design treatment that flows nicely with the rest of the links.

@noisysocks noisysocks added Needs Design Needs design efforts. [Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field labels Aug 19, 2020
@draganescu
Copy link
Contributor

Related #22071

@aristath
Copy link
Member

Isn't this something that a theme should do?

@noisysocks
Copy link
Member Author

Isn't this something that a theme should do?

Blocks come with base styles that a theme can then add to. We should ensure that the base styles are a good place for a theme to start from.

@shaunandrews
Copy link
Contributor

The Search block is getting some customization options in #24666 — I'm not sure there's much the Navigation block needs to do here other than (maybe) toggle the Search label off when added to a horizontal Navigation block.

@draganescu
Copy link
Contributor

I updated this to reflect the work on updating the search block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Search Affects the Search Block - used to display a search field
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants