-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Screen: Show block toolbar with menu name #24580
Comments
The block toolbar was disabled in #23021 because none of its buttons were useful in the context of the Navigation screen. It does look a bit disconcerting now, but if we're going to bring it back we need to think carefully what needs to be displayed in it. There might not be anything useful in the "More options" dropdown for instance. |
Hmm, "copy" for the Navigation block might be tricky in this context, because there's nowhere to copy it to. Creating a new menu always generates a new block, and we can't nest Navigation blocks. Option 2, without the button, seems good! |
I've started working on this and the only problem is that we don't have any menu details. Worse is that the whole process assumed we'll never have "menu" properties to care about. |
Superseded by #28856. |
When the Navigation block is selected it's block toolbar is not shown. In the screenshot below you can see the empty space above the block where I'd expect to see the Navigation block toolbar:
We should show the toolbar and have it display the menu's name:
The text was updated successfully, but these errors were encountered: