Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Screen: Show block toolbar with menu name #24580

Closed
shaunandrews opened this issue Aug 14, 2020 · 5 comments
Closed

Navigation Screen: Show block toolbar with menu name #24580

shaunandrews opened this issue Aug 14, 2020 · 5 comments
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@shaunandrews
Copy link
Contributor

When the Navigation block is selected it's block toolbar is not shown. In the screenshot below you can see the empty space above the block where I'd expect to see the Navigation block toolbar:

image

We should show the toolbar and have it display the menu's name:

image

@tellthemachines
Copy link
Contributor

The block toolbar was disabled in #23021 because none of its buttons were useful in the context of the Navigation screen. It does look a bit disconcerting now, but if we're going to bring it back we need to think carefully what needs to be displayed in it. There might not be anything useful in the "More options" dropdown for instance.

@shaunandrews
Copy link
Contributor Author

shaunandrews commented Aug 19, 2020

At the very least, I'd expect to have the copy item:

image

If there's nothing to show, then I could see us just removing the button:

image

@tellthemachines
Copy link
Contributor

Hmm, "copy" for the Navigation block might be tricky in this context, because there's nowhere to copy it to. Creating a new menu always generates a new block, and we can't nest Navigation blocks. Option 2, without the button, seems good!

@draganescu
Copy link
Contributor

I've started working on this and the only problem is that we don't have any menu details.

Worse is that the whole process assumed we'll never have "menu" properties to care about.

@draganescu draganescu linked a pull request Dec 1, 2020 that will close this issue
6 tasks
@draganescu draganescu assigned grzim and unassigned draganescu Feb 18, 2021
@talldan
Copy link
Contributor

talldan commented Mar 17, 2021

Superseded by #28856.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants