Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover block spacing unit defaults to null #24245

Closed
jffng opened this issue Jul 28, 2020 · 2 comments · Fixed by #24251
Closed

Cover block spacing unit defaults to null #24245

jffng opened this issue Jul 28, 2020 · 2 comments · Fixed by #24251
Assignees
@ItsJonQ
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jffng
Copy link
Contributor

jffng commented Jul 28, 2020 •
edited
Loading

This issue is about the experimental custom spacing controls recently added to the cover block.

The default unit of the padding input appears as "NULL", and changing this value doesn't affect the padding:

Kapture 2020-07-28 at 10 15 31

You can get around this by adding a unit (e.g. "100px"), but it could be nicer to default to some unit here.
@jffng jffng mentioned this issue Jul 28, 2020
Merged
@kjellr kjellr added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jul 28, 2020
@kjellr
Copy link
Contributor

kjellr commented Jul 28, 2020

cc @ItsJonQ do you have any idea what's going on here?

@kjellr kjellr added the [Type] Bug An existing feature does not function as intended label Jul 28, 2020
@ItsJonQ
Copy link

ItsJonQ commented Jul 28, 2020

Oo! Lemme take a looksy. Thanks!

@ItsJonQ ItsJonQ self-assigned this Jul 28, 2020
@ItsJonQ ItsJonQ mentioned this issue Jul 28, 2020
Merged
4 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ItsJonQ ItsJonQ

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cover: Fix padding controls showing null units WordPress/gutenberg
3 participants
@kjellr @ItsJonQ @jffng