Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility regression: The gallery block images buttons miss a focus style #24095

Closed
afercia opened this issue Jul 21, 2020 · 0 comments · Fixed by #24157
Closed

Accessibility regression: The gallery block images buttons miss a focus style #24095

afercia opened this issue Jul 21, 2020 · 0 comments · Fixed by #24157
Assignees
@youknowriad
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Jul 21, 2020 •
edited
Loading

Describe the bug

In WordPress 5.5 Beta 2, the buttons of the images in the Gallery block don't have a focus style.
See below: Move buttons, the new Replace button, and the Remove button:

Screenshot 2020-07-21 at 16 56 06

In WordPress 5.4 they had a focus style: a change in the shape / color of the outline:

Screenshot 2020-07-21 at 14 49 55

Any interactive control needs a clearly visible focus style. This is an accessibility regression compared to the previous released version and should hopefully be fixed soon.

To reproduce:

  • use the keyboard
  • tab through the Gallery block UI

Aside: The Gallery block has many pre-existing accessibility problems but these are out of the scope of this issue. Will try to create a specific report as soon as I find some time.
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release [a11y] Keyboard & Focus labels Jul 21, 2020
@talldan talldan added the CSS Styling Related to editor and front end styles, CSS-specific issues. label Jul 23, 2020
@youknowriad youknowriad mentioned this issue Jul 23, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the gallery buttons focus style WordPress/gutenberg
3 participants
@youknowriad @talldan @afercia