Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Cover: Allow creating the block with custom colour (without an image) #23868

Closed
antonis opened this issue Jul 10, 2020 · 0 comments · Fixed by #23870
Closed

[Mobile] Cover: Allow creating the block with custom colour (without an image) #23868

antonis opened this issue Jul 10, 2020 · 0 comments · Fixed by #23870
Assignees
@antonis
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.

Comments

@antonis
Copy link
Member

antonis commented Jul 10, 2020

Is your feature request related to a problem? Please describe.
The user is not able to create a cover block with only colour and without an image

Describe the solution you'd like
Additionally to the palette with four default colours a Custom Colour Swatch should be added bellow the Add Media Button. When the user taps on the custom colour picker UI shows. The user can tap "Cancel" to go back, or "Apply" to proceed with applying the colour.

83098993-a187c680-a071-11ea-83d4-4ae56f6c5850

Additional Context
This issue is part of breaking down issue wordpress-mobile/gutenberg-mobile#2275 into smaller subtasks. Opening the new tickets here as part of the GB-Mobile Monorepo migration.
This was referenced Jul 10, 2020
Closed
Merged
@annezazu annezazu added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jul 10, 2020
@antonis antonis self-assigned this Jul 14, 2020
@antonis antonis linked a pull request Jul 14, 2020 that will close this issue
[Mobile] Create cover block with custom colour (without an image) #23870
Merged
6 tasks
@antonis antonis mentioned this issue Jul 24, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonis antonis

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Mobile] Create cover block with custom colour (without an image) antonis/gutenberg
2 participants
@antonis @annezazu