Navigation screen: Add support for advanced menu properties

[noisysocks]

The existing nav-menus.php page supports a bunch of advanced menu properties which can be found by enabling them in Screen Options (top right).

To maintain backwards compatibility, our new Navigation screen will need to support these properties as well.

• Link Target
  • What it is: The link's target attribute.
  • Does Navigation block support it: Yes, via the Open in new tab checkbox when inserting a link.
  • Action required: None.
• Title Attribute
  • What it is: The link's title attribute.
  • Does Navigation block support it: No.
  • Action required: Add a freeform text field to the Block Settings for a Link block.
• CSS Classes
  • What it is: The link's class attribute.
  • Does Navigation block support it: Yes, via the Additional CSS class(es) text field in Block Settings.
  • Action required: Show Block Settings in the Navigation screen.
• Link Relationship (XFN)
  • What it is: The link's rel attribute.
  • Does Navigation block support it: Partial. We support setting rel="nofollow" via the Add nofollow to link checkbox.
  • Action required:
    • Swap Add nofollow to link checkbox for Link rel text field (Remove the SEO settings block from the nav block #23153 (comment)).
    • Show Block Settings in the Navigation screen.
• Description
  • What it is: Used in some themes.
  • Does Navigation block support it: Yes, via the Description text box.
  • Action required: Show Block Settings in the Navigation screen.

[noisysocks]

@shaunandrews: Any thoughts on how to show Block Settings in the Navigation screen?

[draganescu]

This issue ties in perfectly with adding an inspector in this screen. It's also required for customising the new blocks that can be added to navigation.

[shaunandrews]

I think all of this would be solved by introducing the block settings UI, like outlined in #23934 (comment)

[noisysocks]

Yep. Moving this to Blocked as it relies on #23934 to be done first.

[noisysocks]

#24669 added Block Settings to the screen. We'll ned to wire up the various controls that Navigation supports, though. Right now setting them does nothing.

[talldan]

At the same time, there are some block inspector options that won't work in the navigation screen.

That mostly seems to be on the nav block itself (Typography, Show submenu indicator icons). I guess there's no plan to support these, so should they be removed?

I think we did the same for some of the toolbar options in the nav block, so it might be fairly straightforward to do the same.

[noisysocks]

That mostly seems to be on the nav block itself (Typography, Show submenu indicator icons). I guess there's no plan to support these, so should they be removed?

Yes I think let's remove these, at least for now.

[tellthemachines]

Closing as all the required features have been implemented.