-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation screen: Add support for advanced menu properties #23731
Comments
@shaunandrews: Any thoughts on how to show Block Settings in the Navigation screen? |
This issue ties in perfectly with adding an inspector in this screen. It's also required for customising the new blocks that can be added to navigation. |
I think all of this would be solved by introducing the block settings UI, like outlined in #23934 (comment) |
Yep. Moving this to Blocked as it relies on #23934 to be done first. |
#24669 added Block Settings to the screen. We'll ned to wire up the various controls that Navigation supports, though. Right now setting them does nothing. |
At the same time, there are some block inspector options that won't work in the navigation screen. That mostly seems to be on the nav block itself (Typography, Show submenu indicator icons). I guess there's no plan to support these, so should they be removed? I think we did the same for some of the toolbar options in the nav block, so it might be fairly straightforward to do the same. |
Yes I think let's remove these, at least for now. |
Closing as all the required features have been implemented. |
The existing
nav-menus.php
page supports a bunch of advanced menu properties which can be found by enabling them in Screen Options (top right).To maintain backwards compatibility, our new Navigation screen will need to support these properties as well.
target
attribute.title
attribute.class
attribute.rel
attribute.rel="nofollow"
via the Add nofollow to link checkbox.The text was updated successfully, but these errors were encountered: