Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching back to Defaul Block Style not possible #23264

Closed
silvanarnet opened this issue Jun 18, 2020 · 6 comments
Closed

Switching back to Defaul Block Style not possible #23264

silvanarnet opened this issue Jun 18, 2020 · 6 comments
Labels
Needs Testing Needs further testing to be confirmed.

Comments

@silvanarnet
Copy link

Describe the bug
Since Version 8.3.0 it's not possible to remove a selected Block Style, unless removing the additional css class by hand.

To reproduce
Steps to reproduce the behavior:

  1. Add the Quote Block
  2. Select a block style
  3. try to remove it

Expected behavior
like in version 8.2.1 or by clicking again on the block style selector (would be nice)

Screenshots
If applicable, add screenshots to help explain your problem.

Editor version (please complete the following information):

  • WordPress version: 5.4.2
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? installed
  • If the Gutenberg plugin is installed, which version is it? 8.3.0
@youknowriad youknowriad added the Needs Testing Needs further testing to be confirmed. label Jun 18, 2020
@youknowriad
Copy link
Contributor

On my initial tests, I don't reproduce but maybe there's something I'm missing here. @adamziel Any idea here whether it could be related to the default class removal or the refactorings that happened?

@oxyc
Copy link
Member

oxyc commented Jun 19, 2020

Do you mean that clicking an already active block style does not toggle it off?

@silvanarnet
Copy link
Author

Maybe it's because of my custom theme.. can't reproduce it with the twenty twenty theme either.

@adamziel
Copy link
Contributor

@silvanarnet Thank you for reporting! The default style is one of the styles listed in the block inspector:

Zrzut ekranu 2020-06-19 o 11 26 16

To "remove" a style and restore the default one, you simply have to select the style marked as default - it's meant to remove any style-related classes from the block.

I am not sure how to reproduce the issue - do you mean what @oxyc asked? Or do you mean switching back to the default style does not remove the CSS class? Would you mind posting a screen capture gif showing the exact process you're following?

@silvanarnet
Copy link
Author

@adamziel
Copy link
Contributor

Ah gotcha! It sounds like the same issue as #24147 - the good news is that it was just fixed a few days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed.
Projects
None yet
Development

No branches or pull requests

4 participants