-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The inline Inserter position jumps #23081
Comments
Let's get this bug squashed..:) |
I've definitely seen this weirdness before, but I never dug into it to find out exactly what triggered it. Thanks for looking into it and creating this issue, @MichaelArestad! |
I've done some refactoring in #20792 while fixing another bug. I'm not noticing any issues after that. Could you retest with master? |
@ellatrix I tested on master and I'm still seeing it. To reproduce:
|
Due to how difficult it is to reproduce this and the severity, I'm removing this from the 5.5 Must-Haves. |
@youknowriad sounds good as long as we eventually figure it out. Keep up the good work! |
I haven't seen this happen for a while now and I just tested and can't reproduce. I believe the code for the in-between inserter was reworked quite a bit, and it seems much more reliable. I'll close this, but can always reopen or open a new issue if it reoccurs. |
Describe the bug
When hovering over the inserter between blocks, it jumps. At first I thought my animation was problematic when working on the hover delay and animation speed. Then, I looked a bit closer. It seems the Inserter is actually moving causing some serious jank.
To confirm this, I shortened the animation and delay to almost 0. It makes it really clear what is happening. You can see it in this gif:
To reproduce
0.01s
. You might also remove this 80% bit here.Expected behavior
I expect the inserter to not jump.
Editor version (please complete the following information):
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: