Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover: Reset should remove all user changes #23030

Closed
ItsJonQ opened this issue Jun 9, 2020 · 1 comment · Fixed by #23041
Closed

Cover: Reset should remove all user changes #23030

ItsJonQ opened this issue Jun 9, 2020 · 1 comment · Fixed by #23041
Assignees
@ItsJonQ
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress

Comments

@ItsJonQ
Copy link

ItsJonQ commented Jun 9, 2020

Describe the bug

The new Padding controls should remove user changes when "Reset" is clicked. At the moment, it only removes session based changes.

This issue was originally discussed here:
#21492 (comment)

To reproduce

  • sets a value for padding to 20
  • saves the post
  • reloads the editor
  • click reset
  • at this point, the padding value is 20 but reset doesn't work (I expected I'd be able to reset them)

Expected behavior

  • sets a value for padding to 20
  • saves the post
  • reloads the editor
  • click reset
  • Padding should be 0. No padding inline styles
@ItsJonQ ItsJonQ added [Package] Components /packages/components [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Jun 9, 2020
@ItsJonQ ItsJonQ self-assigned this Jun 9, 2020
@oandregal oandregal mentioned this issue Jun 9, 2020
Merged
7 tasks
@ItsJonQ
Copy link
Author

ItsJonQ commented Jun 9, 2020

Enhancements! Showing blue highlights when interacting with the inputs:

Screen Capture on 2020-06-09 at 14-37-40

Wonderful feedback/suggestions from @paaljoachim + @ZebulanStanphill

via: #21492 (comment)

@ItsJonQ ItsJonQ mentioned this issue Jun 9, 2020
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ItsJonQ ItsJonQ

Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cover: Padding: Fix reset + Visualize on hover WordPress/gutenberg
1 participant
@ItsJonQ