Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover: Video - Add position controls #22509

Closed
ItsJonQ opened this issue May 20, 2020 · 5 comments · Fixed by #22531
Closed

Cover: Video - Add position controls #22509

ItsJonQ opened this issue May 20, 2020 · 5 comments · Fixed by #22531
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@ItsJonQ
Copy link

ItsJonQ commented May 20, 2020

At the moment, the horizontal and vertical background positioning controls only work for Cover images. Cover videos lack this feature.

Screen Capture on 2020-05-20 at 17-33-12

I think it would be helpful to add feature parity with video backgrounds.

To achieve the same positioning MATH, <video /> styles can use object-position.

This will also give as an opportunity to improve the FocalPointPicker component a bit.

I've done some explorations! I've added couple of enhancements, including adding our new UnitControl components as well as a Grid overlay. It feels really nice!

Screen Capture on 2020-05-20 at 17-19-09

Note: This does not work on IE 11. However, video backgrounds already use object-fit: cover. So this update should not introduce a regression on IE 11.

@ItsJonQ ItsJonQ added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels May 20, 2020
@ItsJonQ ItsJonQ self-assigned this May 20, 2020
@ZebulanStanphill ZebulanStanphill added the [Type] Enhancement A suggestion for improvement. label May 21, 2020
@mtias
Copy link
Member

mtias commented May 21, 2020

This is great. I think the grid should always show up while you drag instead of being a toggle.

@ItsJonQ
Copy link
Author

ItsJonQ commented May 21, 2020

@mtias Oh interesting!!! That makes it easier. We can do that ❤️ !

@ItsJonQ
Copy link
Author

ItsJonQ commented May 21, 2020

focal-demo

@mtias Aww yiss!

(Also in the demo, pressing keyboard arrows to adjust position. Shift jumping is supported)

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 21, 2020
@jasmussen
Copy link
Contributor

jasmussen commented May 22, 2020

Looks amazing, Q! Here's a visual tweak to the field:

Focal point picker

What do you think?

@ItsJonQ
Copy link
Author

ItsJonQ commented May 22, 2020

@jasmussen Sure thing! I can give it a shot ✨

I opened a draft PR:
#22531

We can collab and iterate there 😊

Since we're working on this component... I think it would be a good opportunity to explore any UI/UX ideas.

The "wouldn't it be cool if..." ones.

I think the 9x9 grid as a good example of this. Made better by @mtias 's interaction suggestion

@ItsJonQ ItsJonQ removed the [Status] In Progress Tracking issues with work in progress label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants