Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centre Aligned Image is no Longer Centre Aligned in Editor Again #22461

Closed
iamtakashi opened this issue May 19, 2020 · 5 comments
Closed

Centre Aligned Image is no Longer Centre Aligned in Editor Again #22461

iamtakashi opened this issue May 19, 2020 · 5 comments
Labels
[Block] Image Affects the Image Block [Status] Needs More Info Follow-up required in order to be actionable. [Type] Regression Related to a regression in the latest release

Comments

@iamtakashi
Copy link

This issue was fixed once in #21885 and the PR #21911, but it seems we have the same issue now again.

A centred image is no longer centre-aligned in the editor if the latest Gutenberg is activated. It's easy to see a small image like a thumbnail. The image appears centred on the front of the site.

With Gutenberg plugin:
Screenshot 2020-05-19 at 11 56 52

Without Gutenberg Plugin:
Screenshot 2020-05-19 at 11 54 54

Tested with Mac Chrome, Twenty Twenty theme.

@talldan talldan added [Block] Image Affects the Image Block [Type] Regression Related to a regression in the latest release Needs Testing Needs further testing to be confirmed. labels May 22, 2020
@annezazu
Copy link
Contributor

@iamtakashi for clarity, was this image previously centered aligned before the update and then the 8.3 update unaligned the image? In trying to test this, I'm able to center align images without a problem.

@annezazu annezazu added [Status] Needs More Info Follow-up required in order to be actionable. and removed Needs Testing Needs further testing to be confirmed. labels Jun 18, 2020
@iamtakashi
Copy link
Author

@annezazu, thanks for looking into this.

I'm pretty sure there was a regression when I opened this issue, but as you noted, I now can make an image centre-aligned.

However, I find it weird that selecting a centred image shifts the image left-aligned though. I'm not sure if this is intentional, but if you think this needs to be reported as a new issue, let me know.

centred-image

Tested with 8.3.0 with Twenty Twenty theme.

@annezazu
Copy link
Contributor

annezazu commented Jun 23, 2020

Wow! That's super weird. I tried replicating using 8.3.0 with Twenty Twenty and WordPress 5.4.2. I weirdly couldn't replicate this: https://cloudup.com/cdMbOc3N0xj Do you have any other plugins on the site? For context, the test site I'm using doesn't have any additional plugins active.

@iamtakashi
Copy link
Author

Sorry, @annezazu. I found a third-party plugin causing the shifting issue. I should've disabled all the additional plugins before reporting the shifting issue. I'll make sure that next time.

Since I can't see the regression anymore, I'm closing this issue.

@annezazu
Copy link
Contributor

All good here :) Thanks for finding the problem and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Status] Needs More Info Follow-up required in order to be actionable. [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

3 participants