Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link in link dialogue navigate the user to the page within the site editor #22432

Closed
MichaelArestad opened this issue May 18, 2020 · 5 comments
Assignees

Comments

@MichaelArestad
Copy link
Contributor

This is an idea previously shared in #19204. If you are familiar with Google Docs, this concept should be familiar. In Google Docs, if you click a link, a popover shows up with editing controls and a clickable link. We could do something similar.

Try the prototype.

2020-05-18 12 45 17

Notes

This does require many clicks but is likely more discoverable initially than hotkeys. It also doesn't require any new UI patterns.

Screenshot

image

Source Figma file

@MichaelArestad
Copy link
Contributor Author

Prototype i2

I tried another iteration that uses a button instead of the link. This likely could be more predictable. I did take the liberty of changing the "Change" button to a "Remove link" button.

Try the prototype.

2020-06-19 14 59 58

I'm not entirely sold on the icon. I tried a few edit icons, but that felt very much like I was editing the link and not going to a page to edit. I'm open to ideas here.

Screenshot

image

Source Figma file

@folletto
Copy link
Contributor

folletto commented Jul 1, 2020

This seems a strong baseline. I define here baseline as: we might be building something faster and swifter than this later, but we can always have this as a fallback. So regardless of other, maybe more advanced interfaces, this seems the right place and with enough space to be clear on the action, and navigate around.

I would be maybe even more explicit instead of icons, here are two options to brainstorm further:

Option 1
More explicit, makes used of the existing dropdown, I think major win for clarity once we get the copy right.
Screenshot 2020-07-01 at 18 30 21

Option 2
Harder for translations, and adds a lot in the toolbar, but it's very quick to access.
Screenshot 2020-07-01 at 18 30 16

@MichaelArestad
Copy link
Contributor Author

@shaunandrews has proposed a series of iterations to the link UI that render this mockup fairly outdated. In his mocks, he proposed this:

image

I think it works well with the new UI particularly as it's not relying on an icon. What do you think?

@folletto
Copy link
Contributor

Just having a single chevron down might be a little too "cryptic" — maybe having a label too would help? or some way to separate it from "Done"? — but apart from that I think it's a solid solution.

I think the copywriting needs some iterations (I think it's important it highlights better what's going to happen), but again, it's just a minor review step.

@kellychoffman
Copy link
Contributor

Closing this due to lack of activity and to make it part of #23328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants