Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Not adding a submenu the "Add link..." remains and is not automatically deleted. #21448

Closed
paaljoachim opened this issue Apr 7, 2020 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 7, 2020

Related #21450

Describe the bug
"Add link..." remains even though one might have changed ones mind in adding a submenu.
To remove it one needs to click into it and add some letters (or click into it and then go to the toolbar select the 3 dots menu and select remove block). Then select the container around it which is hard to see and then click delete on the keyboard.

Steps:

Click menu item. Then click to Add Submenu.

Screen Shot 2020-04-07 at 10 01 11

Then change your mind. No submenu is needed anyway.

"Add link..." remains even though one have not added a submenu.

hard-to-remove-add-to-link

One then needs to either click into the "Add link..." area and then go to the toolbar, click the 3 dots menu and remove block or write some letters into the area then select it and click the delete key on the keyboard.

Solution I would like to see:
The "Add link..." should when not adding a submenu be automatically removed.

Gutenberg 7.8.1
Chrome
Live dev site

(Adding the following info here as well)
William as you worked on the Permalink PR. #12009
When not saving and clicking outside of the box the Permalink would automatically close. I am thinking the same method can be used on this issue and the related adding top level menu item issue I made. #21450
@earnjam

@talldan
Copy link
Contributor

talldan commented Apr 20, 2020

This seems like a very similar issue to #21450, it might be possible to consolidate them.

The only thing that differs is that the 'Add Submenu' button perhaps doesn't make it clear that it'll add a block in a submenu and that removing that block will remove the submenu. I think that might be where the confusion is coming from.

I'll add the Needs design feedback label.

@talldan talldan added Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block labels Apr 20, 2020
@draganescu
Copy link
Contributor

This is a duplicate of #21848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

3 participants