Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block submenus inaccessible on IE #21136

Closed
tellthemachines opened this issue Mar 25, 2020 · 4 comments · Fixed by #22546
Closed

Navigation block submenus inaccessible on IE #21136

tellthemachines opened this issue Mar 25, 2020 · 4 comments · Fixed by #22546
Assignees
Labels
[Block] Navigation Affects the Navigation Block Browser Issues Issues or PRs that are related to browser specific problems [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@tellthemachines
Copy link
Contributor

Describe the bug

On IE11, Navigation block submenu dropdowns don't open when the parent block is hovered or focused. The focus behaviour is relying on :focus-within, which isn't supported on IE, but I'm not sure why the hover functionality also doesn't work.

Because the styles for hiding the dropdown use visibility: hidden there's also a risk it won't be accessible on screen readers if using IE.

To reproduce
Steps to reproduce the behavior:

  1. Create a new post.
  2. Add navigation block and create a submenu for one of the items.
  3. On IE, try to access the submenu by hovering or focusing on the parent item.
  4. Verify that submenu remains hidden.

Expected behavior

Expected submenu to be accessible on IE.

Screenshots

subnav-closed

@tellthemachines tellthemachines added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Mar 25, 2020
@noisysocks
Copy link
Member

This is tough to fix, yeah? Would a different design approach to submenus help? cc. @karmatosed

@karmatosed
Copy link
Member

@noisysocks just noting here that @enriquesanchez is going to take a look at this and see what can be done.

@enriquesanchez
Copy link
Contributor

I was able to hover on the submenu items but only if I was quick to move my mouse to that area:

2020-04-30 17-16-27 2020-04-30 17_19_46

Perhaps if we introduced a delay before the submenus fade out this could get fixed?

@tellthemachines
Copy link
Contributor Author

The hover was fixed for IE with #21471 (we might need to adjust the hover area a bit so it works better, but at least it works now), but focus is still not working at all, because we're using the focus-within selector which is not supported in IE.

We can fix this by tracking when focus is inside the dropdown and adding a classname to the parent that we can then attach the focus styles to. It should be fairly straightforward.

@noisysocks noisysocks added the Browser Issues Issues or PRs that are related to browser specific problems label May 20, 2020
@tellthemachines tellthemachines self-assigned this May 22, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Browser Issues Issues or PRs that are related to browser specific problems [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants