Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include vertical alignment options in Cover and Columns block #20901

Closed
enriquesanchez opened this issue Mar 13, 2020 · 3 comments
Closed

Include vertical alignment options in Cover and Columns block #20901

enriquesanchez opened this issue Mar 13, 2020 · 3 comments
Labels
[Block] Columns Affects the Columns Block [Block] Cover Affects the Cover Block - used to display content laid over a background image

Comments

@enriquesanchez
Copy link
Contributor

It'd be great if more blocks such as 'Cover' and 'Columns' had the same vertical alignment features that are found in the 'Media & Text' block:

Screen Shot 2020-03-13 at 16 41 41

This feature, if also applied to text child blocks, will allow for more control over text layout and alignment.

See #20900 for a comparison between what was intended and what was actually possible with Gutenberg.

@enriquesanchez enriquesanchez added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Columns Affects the Columns Block labels Mar 13, 2020
@phpbits
Copy link
Contributor

phpbits commented Mar 14, 2020

I have this feature added on EditorsKit plugin few months ago and here's the preview on how I've implemented the vertical alignment on Cover Block. I used verticalAlignment attribute similar to what Columns block is using. Thanks!

Cover Block vertical alignment (24)

https://twitter.com/phpbits/status/1202628628443324416

@paaljoachim
Copy link
Contributor

paaljoachim commented Mar 14, 2020

Thanks for sharing the method you used for Editor's Kit, Jeffrey! I am thinking we could perhaps do something similar for Gutenberg Core Cover Block. I do believe these days there are an overhaul of the various alignment options happening. To figure out how to better represent these in the toolbar.

@enriquesanchez
Copy link
Contributor Author

Thank for the feedback and examples @phpbits and @paaljoachim!

I'm closing this issue in favor of #20836, which is addressing the same topic and already has some design explorations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Block] Cover Affects the Cover Block - used to display content laid over a background image
Projects
None yet
Development

No branches or pull requests

3 participants