-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover: internal alignment / position #20836
Comments
Added a new icon-position in the icon Figma library. |
Yes, that's why in the original I was using gray for the non active ones. It's a nice detail, I think. |
👋 Haiii! I started experimenting with creating the AlignmentControl component. I have a working prototype here: 👩💻 Code ✨ Demo The Demo showcases an Some notable features:
|
@pablohoneyhoney I've made adjustments to my prototype to better match your designs! Due to the dynamic nature of the icon, from a technical perspective, I think it may be better to create it using HTML/CSS rather than SVG. But, we'll match the Icon dimension/sizes as best as possible to ensure that it looks consistent with the other icons. |
Started coding it! Working branch: So far, I've focused exclusively on the new Control component. |
@pablohoneyhoney Yes! I've experimented with direct controls in my prototype: Although, the aesthetics I have make them look like 9 cells/boxes, rather than points (like yours). But the idea is the same :). One tricky thing re: the Direct manipulation overlay. For example (not saying this is how it should be):
Hope this makes sense 🙏 |
I think we should get it into the toolbar first — I can see multiple issues with the in-canvas presentation based on background / image / video presence in the cover block. We could revisit this in conjunction with #20193 |
The Cover block is a pretty nice tool. However, its internal positioning is quite inflexible. You can align individual blocks to left / right / center, but not a group, and not vertically.
It'd be neat to explore some more cardinal positions:
Combining them in a single tool should help with clarity:
Since there is no internal width or padding (at least until the work on dimensions in "Group" is finalized), you should still be able to flush individual blocks to the left or right even with a default set:
The text was updated successfully, but these errors were encountered: