Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Wrong" character in title #19898

Closed
Sven74Muc opened this issue Jan 26, 2020 · 6 comments · Fixed by #19955
Closed

"Wrong" character in title #19898

Sven74Muc opened this issue Jan 26, 2020 · 6 comments · Fixed by #19955
Assignees
Labels
[Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@Sven74Muc
Copy link

Sven74Muc commented Jan 26, 2020

I have the Gutenberg 7.3.0 plugin installed but the issue happend also with former versions. Deactivating the Gutenberg plugin and the issue is gone.

What happened.

I post a new post (not page) with an apostrophe (') in the title. Within the database there is no apostrophe, instead there is & # 3 9 ; (without spaces) written.
On the webpage there is no issue, this will be tranformed back to an apostroph... but Mailpoet does this not. Within my newsletters (new post notification) it will we used exactly what is in the database, means "What's" will be displayed as "What& # 3 9 ;s" (without spaces).

Think Mailpoet is not the only plugin (while it is a very common plugin) which displays exactly the database entry.

Keywords: unicode, apostrophe, post title, encoding

@Sven74Muc
Copy link
Author

Any update here?

@Sven74Muc
Copy link
Author

@aduth
Copy link
Member

aduth commented Jan 29, 2020

This behavior seems to have been introduced with #18616.

It's not strictly wrong to escape the entities (replace the apostrophe), in that the output is valid HTML which can be faithfully represented on the front of the site and anywhere else which can display HTML. If Mailpoet is unable to unable to handle this sort of HTML, then that is perhaps an issue that they need to fix.

That being said, I don't think it's needed or desirable to escape these characters in the title:

  • It will cause default title "texturize" behavior to skipped, because these characters are only replaced if left unescaped (source).
  • It is intended that titles can include HTML, which this behavior would prevent.
  • Evidenced by this issue, it may be more prone to interoperability issues with other plugins and services.

Recommendation: Revert #18616

cc @retrofox @obenland

@aduth aduth added [Package] Editor /packages/editor [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. [Type] Bug An existing feature does not function as intended labels Jan 29, 2020
@Sven74Muc
Copy link
Author

Sven74Muc commented Jan 29, 2020

Sure, Mailpoet can work on this, too. But why don't we fix it directly in Wordpress / Gutenberg? Any point which points against this?

My point is, that Mailpoet will not be the only plugin which use exactly what is written in the database, so solving it on the Gtenberg editor end would be the best solution.

@aduth
Copy link
Member

aduth commented Jan 29, 2020

@Sven74Muc I recommended a change in Gutenberg in my previous comment.

Recommendation: Revert #18616

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 29, 2020
@Sven74Muc
Copy link
Author

@aduth thanks for taking over this issue and adding this to WordPress 5.4 Must Have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants