Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking into text blocks doesn't always allow you to edit. #19731

Closed
kjellr opened this issue Jan 17, 2020 · 12 comments · Fixed by #19839
Closed

Clicking into text blocks doesn't always allow you to edit. #19731

kjellr opened this issue Jan 17, 2020 · 12 comments · Fixed by #19839
Assignees
Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Jan 17, 2020

Describe the bug

Using the latest version of master, I've noticed that sometimes I'm unable to click into RichText blocks and edit them (Paragraph, Header, List, etc.).

I haven't been able to track down exact replication steps yet, but I've seen it happen a handful of times now, usually while composing longer posts. When it occurs, the only remedy I've found is to save the post and reload the page.

Screenshots

In the GIF below, it's possible to edit the code block, but not the paragraph block:

editing

Desktop (please complete the following information):

  • MacOS 10.15.2
  • Safari 13.0.4
@kjellr kjellr added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. labels Jan 17, 2020
@simison
Copy link
Member

simison commented Jan 21, 2020

Happens to me quite often with Macos Firefox and Chrome.

@talldan talldan added [Priority] High Used to indicate top priority items that need quick attention and removed Needs Testing Needs further testing to be confirmed. labels Jan 22, 2020
@talldan
Copy link
Contributor

talldan commented Jan 22, 2020

Yes, I noticed this for the first time yesterday as well with the navigation block. It seemed to be ok for the first few clicks and then started happening. Raising the priority as this seems like an important bug to fix.

@ellatrix
Copy link
Member

When do you think it started happening? Did you select multiple blocks right before?

@ellatrix
Copy link
Member

I suspect it's related to multi selection no re-enabling the rich text fields but I wonder what is triggering it.

@kjellr
Copy link
Contributor Author

kjellr commented Jan 22, 2020

When do you think it started happening? Did you select multiple blocks right before?

For me, It seems to happen just in the course of clicking in and out of individual blocks, not rearranging or selecting multiple blocks.

@ellatrix
Copy link
Member

Could someone test again with the latest master or the latest Gutenberg release? I have a feeling that #19720 might have fixed the issue. Otherwise I'll investigate further.

I reproduced it (don't know the steps) with 7.2.0, so it’s not a regression in 7.3.0. I did see that editing was disabled, so it definitely has to do with multi selection (attempts).

@talldan
Copy link
Contributor

talldan commented Jan 23, 2020

I'm still experiencing it on master @ellatrix. It takes a lot of clicking around for it to happen.

I think it must be related to the code in the PR you linked to, particularly the node.removeAttribute( 'contenteditable' ); part. The paragraphs that had the bug didn't have the contenteditable attribute set. I think this is causing the RichText's onFocus not to trigger, meaning the selectionChange action isn't called.

@ellatrix
Copy link
Member

Thanks for testing! I'll look into it today

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 23, 2020
@ellatrix
Copy link
Member

#19839 should fix thee issue.

@AdrienM76
Copy link

If it helps any, I am able to reproduce it consistently simply by trying to move a block using the move widget. (not sure what it is called) I'm not familiar with installing and testing master, but I'll see what I can do.

@ZebulanStanphill
Copy link
Member

This looks like it may be the same issue as #18977. #19839 appears to fix both, so I guess they are the same, or at least both caused by the same root problem.

@OceanWind
Copy link

This is still an issue with the block editor in WordPress v5.8.1. It seems to be related to copying multiple blocks. Once that's done, clicking into certain blocks does not allow you to edit the text. If you delete the block and undo the deletion, you can edit again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants