-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Block: when the site doesn't have published Pages initial suggestions shows a blank popover. #19628
Comments
I don't think it'd be an issue after #18900. Also by default there should at least be an about page, a hello world post, etc. |
Yup, it's right.
Agree that it's an edge case but it's possible. |
I take your point, I'm not 100% sure this covers the same issue. Granted, you will be able to create a new Page from the Nav but I can imagine Users creating some Pages from within the It could perhaps be confusing to not see these appear. Especially for new users. What do we think? I wonder whether Design could give us their view here as well @karmatosed? |
I mocked up a few quick ideas for how we could add a message to the default state of the Link UI when a site has no published content — including and excluding the possible "Create new" button. I'm not sure the message is super helpful on its own, and when paired with the "Create new" button I find it visually unbalanced. Instead, I think it might be better to show some messaging once the user starts typing in the search input: |
@shaunandrews I think I agree with you on the last one being the best there. I like the add new page there and wonder if this could extend for other content (add post, add custom post type). My only wonder still which I feel might just be me is the '+', is there an option without that? |
I don't think this is still an issue, as with #18900 where there is no page you are offered the suggestion to make a new one. Therefore I will close but if I am wrong feel free to reopen. |
Originally posted by @retrofox in #19458 (comment)
Wondering if we should show a message about this. Anyway. probably out of this scope. Feel free to ignore it.
Is this an issue? If so should we show a message here but I'm thinking it might create more confusion.
The text was updated successfully, but these errors were encountered: