Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: when the site doesn't have published Pages initial suggestions shows a blank popover. #19628

Closed
getdave opened this issue Jan 14, 2020 · 6 comments
Assignees
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Question Questions about the design or development of the editor.

Comments

@getdave
Copy link
Contributor

getdave commented Jan 14, 2020

Originally posted by @retrofox in #19458 (comment)

...what happens when the site doesn't have published entries. It shows a blank popover:

Wondering if we should show a message about this. Anyway. probably out of this scope. Feel free to ignore it.

Is this an issue? If so should we show a message here but I'm thinking it might create more confusion.

@getdave getdave added [Block] Navigation Affects the Navigation Block [Type] Question Questions about the design or development of the editor. Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. labels Jan 14, 2020
@mtias
Copy link
Member

mtias commented Jan 14, 2020

I don't think it'd be an issue after #18900. Also by default there should at least be an about page, a hello world post, etc.

@retrofox
Copy link
Contributor

I don't think it'd be an issue after #18900

Yup, it's right.

Also by default there should at least be an about page, a hello world post, etc.

Agree that it's an edge case but it's possible.

@getdave
Copy link
Contributor Author

getdave commented Jan 16, 2020

I don't think it'd be an issue after #18900

I take your point, I'm not 100% sure this covers the same issue. Granted, you will be able to create a new Page from the Nav but I can imagine Users creating some Pages from within the Pages area of the WP Dashbord but not publishing them. They might then expect to be able to add these to the Nav Block because they are not yet fully aware of the importance of the Post Status.

It could perhaps be confusing to not see these appear. Especially for new users. What do we think?

I wonder whether Design could give us their view here as well @karmatosed?

@shaunandrews
Copy link
Contributor

image

I mocked up a few quick ideas for how we could add a message to the default state of the Link UI when a site has no published content — including and excluding the possible "Create new" button. I'm not sure the message is super helpful on its own, and when paired with the "Create new" button I find it visually unbalanced.

Instead, I think it might be better to show some messaging once the user starts typing in the search input:

image

@karmatosed
Copy link
Member

@shaunandrews I think I agree with you on the last one being the best there. I like the add new page there and wonder if this could extend for other content (add post, add custom post type). My only wonder still which I feel might just be me is the '+', is there an option without that?

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jan 21, 2020
@mtias mtias changed the title Nav Block - when the site doesn't have published Pages initial suggestionst shows a blank popover. Navigation Block: when the site doesn't have published Pages initial suggestions shows a blank popover. Mar 10, 2020
@draganescu
Copy link
Contributor

I don't think this is still an issue, as with #18900 where there is no page you are offered the suggestion to make a new one. Therefore I will close but if I am wrong feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

6 participants