Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The appender in the group block is missing icon #19246

Closed
draganescu opened this issue Dec 19, 2019 · 2 comments · Fixed by #19366
Closed

The appender in the group block is missing icon #19246

draganescu opened this issue Dec 19, 2019 · 2 comments · Fixed by #19366
Labels
[Block] Group Affects the Group Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

draganescu commented Dec 19, 2019

Describe the bug
While testing #19135 I noticed that the group block in Firefox 71 is missing the plus Icon (Chrome displays properly)

To reproduce
Steps to reproduce the behavior:

  1. Use Firefox latest
  2. Create a post
  3. Add a group block
  4. See bug

Expected behavior
The appender to have the plus icon

Screenshots

Screenshot 2019-12-19 at 17 48 15

Desktop (please complete the following information):

  • OS: osx
  • Browser Firefox
  • Version 71

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]
@draganescu draganescu added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time [Block] Group Affects the Group Block labels Dec 19, 2019
@glendaviesnz
Copy link
Contributor

Seems to be related to the .block-editor-button-block-appender styles.

If flex-direction: column is disabled it fixes it:
column

but this breaks the alignment in chrome

removing the padding also fixes it, and doesn't break the alignment in chrome:

padding

Ran out of time to work out exactly what the issue is, or what the best fix is sorry.

@bartczyz
Copy link
Contributor

bartczyz commented Dec 30, 2019

Howdy @draganescu!

I noticed this issue on MacOS 10.14.6 / Safari 13.0.4 as well.

IMO the problem is with the height of the element. Since height is not set the element is being squashed by the padding.

Adding height: 100% fixes the problem for me.

I will open a PR later today. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants