Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent closing of settings panels #18418

Open
Tracked by #51104
maddisondesigns opened this issue Nov 9, 2019 · 9 comments
Open
Tracked by #51104

Inconsistent closing of settings panels #18418

maddisondesigns opened this issue Nov 9, 2019 · 9 comments
Assignees
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@maddisondesigns
Copy link

Describe the bug
The panels in the Settings Sidebar are inconsistent on whether they stay open or stay closed when moving between blocks.

Here's a video of six different Heading blocks. When I click between each of them the Color Settings panel constantly closes, but the Advanced panel constantly stays open. It's inconsistent, and extremely annoying when they constantly close.

If I open one panel (the Advanced panel), and it stays open as I move to other blocks, then the same thing should happen when I open another panel (the Color Settings panel), but it doesn't.

Vid: https://cl.ly/b500cff8e9e0

This issues happens on numerous blocks such as the Heading Block and the Paragraph Block (and most likely other blocks, but I haven't checked every single block)

To reproduce
Steps to reproduce the behavior:

  1. Add multiple Heading blocks
  2. Open the Color Settings and Advanced panels in the Settings Sidebar
  3. Select each Block alternately and watch the Color Settings panel constantly close

Expected behavior
Settings Sidebar panels are inconsistent in how they display.

Desktop (please complete the following information):

  • OS: macOS Mojave 10.14.6
  • Browser: Firefox 70.0.1
  • Version: WP 5.3-RC4-46680
@ellatrix ellatrix added [Package] Block editor /packages/block-editor Needs Testing Needs further testing to be confirmed. labels Nov 21, 2019
@karmatosed
Copy link
Member

I can replicate this, thanks for discovering this as always great to soothe inconsistencies. I think this needs a decision on what stays open. My gut says if it's the same block they all should, color included.

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Testing Needs further testing to be confirmed. labels Nov 21, 2019
@karmatosed karmatosed added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Dec 18, 2019
@karmatosed
Copy link
Member

Noting this as good first issue and that making it consistent would be issue.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Dec 18, 2019
@skorasaurus
Copy link
Member

heavily related issues: #27560

@skorasaurus skorasaurus added Needs Decision Needs a decision to be actionable or relevant [Package] Components /packages/components and removed Needs Decision Needs a decision to be actionable or relevant labels Apr 30, 2022
@Saoming
Copy link

Saoming commented Dec 12, 2022

Can I work on this issue?

@skorasaurus
Copy link
Member

Can I work on this issue?

Yes; although if you submit a pull request it may take some time to someone review it.

@Saoming
Copy link

Saoming commented Dec 13, 2022

All good, Thank you @skorasaurus! I am not sure how to assign myself here

@richtabor
Copy link
Member

I actually don't think this is as big of an issue, as many of the default panels are using toolbelt controls (the vertical ellipsis) and remain open by default.

CleanShot.2022-12-20.at.11.08.36-converted.mp4

@maddisondesigns
Copy link
Author

It's probably worth pointing out that this issue was raised 3+ years ago so a lot has changed since then. Although a lot of the Settings Sidebar panels now remain open, they are still wildly inconsistent. Why do some panels allow you to open/close them while others don't?

From what I can tell, it's due to the poor design of some of the controls. Controls like Typography, Colour & Dimensions, for example, require you to "turn on" various options before you can even use them, which is super annoying. The Options icon for these controls is sitting in the same position as the open/close toggle on other panels. You shouldn't have to enable options prior to being able to use them, they should all be available, all the time. No only that, but the fact that enabling them on one block, doesn't automatically enable them on all the other same blocks, is annoying as well. Editing content in Gutenberg is so time consuming and slow because you hide so many controls and options by default, in hidden panels and popups, forcing users to perform multiple unnecessary clicks.

Vid: https://share.getcloudapp.com/YEuDXY8L

@Saoming
Copy link

Saoming commented Feb 10, 2023

I agree with you @maddisondesigns , Maybe it should reduce the toggle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

7 participants