-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try a different pattern for the font size picker #17755
Comments
This is a good direction to try. Let's see if we can get this built rather quickly for WP 5.3. It will require some testing to ensure it's a good solution. |
I commented over on the PR, just to close that loop I will also comment here. Whilst, I understand the reason for exploring this, I do feel this is a problematic direction. It adds a pattern we haven't used yet but is similar to the styles. I also think if you consider adding styles and font sizes, that rapidly becomes a very complex interface to do something simple, change font size. I also have concerns over the cognitive load of that section right now with this added. If I am isolated in this feeling that's fine, but personally, it feels like a direction that needs deeper consideration. |
I agree with @karmatosed, I'd go with @jasmussen's approach: #17759 (comment). |
|
This is also something that theme developers can customize, so you might see there 10 options as well. In addition, people can use any text they like and any size they need so I'm afraid it won't scale. |
@enriquesanchez, thank you for sharing this option. It looks like related PR was closed based on the feedback received, should we close this issue, too? |
This was one of our early concerns as well. If theme devs did customize this, it could get unwieldy pretty quick. |
I'd like to propose we try a different direction that will help address the accessibility issues we've been encountering with previous attempts of the font size picker (#15319, #16148, #17418).
While this solution takes a different direction, it covers all the requirements we need:
In addition, this solutions also informs the user of all the available options at a glance, without the need to interact with a custom select component or menu button in order to find out what's inside.
The text was updated successfully, but these errors were encountered: