Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a different pattern for the font size picker #17755

Closed
enriquesanchez opened this issue Oct 3, 2019 · 7 comments
Closed

Try a different pattern for the font size picker #17755

enriquesanchez opened this issue Oct 3, 2019 · 7 comments
Assignees
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components

Comments

@enriquesanchez
Copy link
Contributor

I'd like to propose we try a different direction that will help address the accessibility issues we've been encountering with previous attempts of the font size picker (#15319, #16148, #17418).

Screen Shot 2019-10-03 at 11 21 22 AM

While this solution takes a different direction, it covers all the requirements we need:

  • It's accessible
  • Visually shows the size of the options
  • Let's the user see which options is currently active

In addition, this solutions also informs the user of all the available options at a glance, without the need to interact with a custom select component or menu button in order to find out what's inside.

@enriquesanchez enriquesanchez added Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts labels Oct 3, 2019
@mapk
Copy link
Contributor

mapk commented Oct 3, 2019

This is a good direction to try. Let's see if we can get this built rather quickly for WP 5.3. It will require some testing to ensure it's a good solution.

@mapk mapk removed the Needs Design Feedback Needs general design feedback. label Oct 3, 2019
@epiqueras epiqueras self-assigned this Oct 3, 2019
@epiqueras epiqueras removed the Needs Dev Ready for, and needs developer efforts label Oct 3, 2019
@karmatosed
Copy link
Member

I commented over on the PR, just to close that loop I will also comment here.

Whilst, I understand the reason for exploring this, I do feel this is a problematic direction. It adds a pattern we haven't used yet but is similar to the styles. I also think if you consider adding styles and font sizes, that rapidly becomes a very complex interface to do something simple, change font size.

I also have concerns over the cognitive load of that section right now with this added. If I am isolated in this feeling that's fine, but personally, it feels like a direction that needs deeper consideration.

@epiqueras
Copy link
Contributor

I agree with @karmatosed, I'd go with @jasmussen's approach: #17759 (comment).

@epiqueras
Copy link
Contributor

#17759 (comment)

It could also be shown below it, as a preview.

Anyway, it looks like we can use Downshift now and stick to the original design: #16473 (comment).

@gziolo
Copy link
Member

gziolo commented Oct 4, 2019

Whilst, I understand the reason for exploring this, I do feel this is a problematic direction. It adds a pattern we haven't used yet but is similar to the styles. I also think if you consider adding styles and font sizes, that rapidly becomes a very complex interface to do something simple, change font size.

This is also something that theme developers can customize, so you might see there 10 options as well. In addition, people can use any text they like and any size they need so I'm afraid it won't scale.

@gziolo
Copy link
Member

gziolo commented Oct 4, 2019

@enriquesanchez, thank you for sharing this option. It looks like related PR was closed based on the feedback received, should we close this issue, too?

@swissspidy swissspidy added [Package] Components /packages/components [Feature] UI Components Impacts or related to the UI component system labels Oct 4, 2019
@mapk
Copy link
Contributor

mapk commented Oct 4, 2019

This is also something that theme developers can customize, so you might see there 10 options as well. In addition, people can use any text they like and any size they need so I'm afraid it won't scale.

This was one of our early concerns as well. If theme devs did customize this, it could get unwieldy pretty quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components
Projects
None yet
Development

No branches or pull requests

6 participants