Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover image: clear media is just clearing settings #17606

Closed
karmatosed opened this issue Sep 26, 2019 · 5 comments
Closed

Cover image: clear media is just clearing settings #17606

karmatosed opened this issue Sep 26, 2019 · 5 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

karmatosed commented Sep 26, 2019

To remove settings you 'clear media' on cover image. For me, this is 'clear' as you aren't removing or clearing any media.

image

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Sep 26, 2019
@richtabor
Copy link
Member

Here are some notes from discussing this in today's Gutenberg Triage meeting (Slack link).

  1. Selecting "Clear Media" essentially resets the block to its placeholder state - although InnerBlocks content remains. Clearing the background color also resets the block to its placeholder state. This "reset" could very well lead folks to believe their InnerBlocks content has been lost - when the block resets to its placeholder state.

  2. Perhaps clearing media or background color settings should not force the block back into its placeholder state. Clearing media or background color would simply return a blank box with whatever InnerBlocks content the user has added to the block. Not only would this improve this interaction, it would add more flexibility to the block by allowing folks not to have background colors/images to the block.

Current Flow when selecting "Clear Media":
cover

@mapk mapk removed the Needs Design Feedback Needs general design feedback. label Dec 17, 2019
@mapk
Copy link
Contributor

mapk commented Dec 17, 2019

Number 2 under @richtabor's comment above makes sense to me. Let's move forward with a try/ PR around this concept.

@mapk mapk added Needs Dev Ready for, and needs developer efforts [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Dec 17, 2019
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 4, 2023
@akasunil
Copy link
Member

akasunil commented Mar 14, 2024

Current implementation of "Clear Media" is as below. It just clear the media attached to cover block background.
Do we required to extend this functionality ? if not, we can close this issue i think. @richtabor

CleanShot 2024-03-14 at 14 39 02

@Mamaduka
Copy link
Member

I think we can close this after #64630 is merged.

@akasunil
Copy link
Member

I'm closing this since the Reset option is available now in toggle bar for the cover block. Added through PR #64630

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants