-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy: Inconsistent capitalization of labels in tooltips and dropdown menus #16764
Comments
@mapk and @karmatosed - do we have guidelines around it? |
From our copy guidelines:
It sounds like we may need to give more examples here to make it super clear for future usage as well. The above rather reads as though tooltips and the like would be classified as "feature labels" (and thus should use sentence case), but the majority of these seem to be using title case. The guidelines for core say that the following should use title case:
Again, this may be a bit vague and warrants further clarification (is a tooltip a label?) once we've decided on a pattern here. More explicit guidelines may be required to ensure a more consistent experience. Seems like most tooltips in wp-admin use sentence case: |
In the example, @sarahmonster shared, there is this exact issue which triggered my willingness to unify everything. You see |
Some past (Dec. 2014) conversation on Slack about title-casing: https://wordpress.slack.com/archives/core/p1418759343002024 Personally, I'm not sure I understand all this extensive usage of title-casing. I do realize it's more a traditional thing in English typography. However, title-casing it's not used in many other countries. In Europe, it's very rarely used. Just have a quick look at the most important online newspapers from France, Germany, Spain, Italy, etc. and even UK: no title-casing there. Can anyone provide an example of a big news site that uses title-casing? I doubt it's used on US big news sites as well. A few quick questions 🙂
I can only tell that one of the items in the Italian polyglots guidelines is to avoid title-casing at all costs. That said, inconsistencies in the admin are everywhere so this is not just a Gutenberg issue. Example: "Remove From Bulk Edit" Any reason why Also, there are cases of slightly excessive usage of title-casing. For example, things like "Log Out Everywhere Else" (formerly "Log Out of All Other Sessions") look a bit excessive to me. Overall, I'd tend to think the intent to reduce inconsistency is very valuable but maybe the best option would be to drastically simplify and just use normal sentence-casing. |
I'm fine with that as well. Whatever makes more sense and makes life simpler for developers, translators, and more importantly users.
The same applies to Polish. Some examples from Facebook: By the way, GitHub uses sentence case for buttons when using English :) |
Based on @sarahmonster's digging, other comments in this thread, and my own personal feelings 😉, I'm much more inclined to use Sentence-case for the tooltips. I'm sure we can add documentation to support this decision, but this can be justified by saying tooltips are not "Labels, Button Labels, or Actions" so we should be good to go. |
Can we loop back to core a patch to also change that? I know it's a big ask but unifying here would be a nice addition. |
Regarding the accessibility of sentence case vs. title case, there does not seem to be any consensus or formal studies that prioritize one over the other. I was able to dig this Microsoft study that briefly touches on the topic of alternating case, which is not exactly what's being discussed here, as it refers to a single word. It does however offer some insights that I think can be expanded to our situation:
I vote for consistency but also maintainability. I think title case will lead to more errors and inconsistency in the future, since it's not an international practice. Also, have y'all seen that we use title case for our GitHub labels? 😝 |
+1 to this 🙂
🙈 |
WordPress uses a lot of title case. I'd love to see us start to shift toward more sentence case where possible:
Some more reading on the topic:
|
@enriquesanchez we use title case for labels because it was used in other interactions. It's a loop where it was first in core then propagated throughout :) |
Can we unpropagate it? Like what if we start using Sentence case in Gutenberg and at least submit a Trac issue for Core? A little reverse-propagation never hurt anyone, right? 😉 |
I’d love to see it happen. It was my intention that we bet on one approach and apply it everywhere. I must admit that seeing GitHub using sentence case for buttons every time I comment here convinced me to follow this approach. 😃 |
* Using sentence case for tooltips. Fixes #16764 in part. * update snapshots * second try to match tests
#17336 fixes it only partially. |
While #17336 fixes the tooltips, we now need another PR to cover the popover component and change those options to Sentence Case too. Examples: |
So far we have only done this in the tooltips and in menus. If sentance case of right approach we should consider taking this across all areas. Included in this: - Side panel - Block library - Settings There may be areas missed, but gives a starting view to see if everyone agrees to go forward with this across everything. If we do, then we need a patch for core. Expands on #16764
* Expanding on sentance case to everywhere else So far we have only done this in the tooltips and in menus. If sentance case of right approach we should consider taking this across all areas. Included in this: - Side panel - Block library - Settings There may be areas missed, but gives a starting view to see if everyone agrees to go forward with this across everything. If we do, then we need a patch for core. Expands on #16764 * Catch a few missed * Update tag * Test catches Fixes test issues. * Catches the test fails for sentance case. * Test fix * Update index.js * Catch some more test fails * Test fixes * Override WP labels for post and page types … to conform to sentence-style capitalisation across the editor UI. (This is a quick commit to show the idea. Do expand on it and polish.) From Slack: "If we used this it would have to be properly marked [e.g. @todo] and commented so that before the next core release we could revisit these labels as a whole." * gutenberg_override_posttype_labels: small fixes
Yep! PR is merged, let's close this! |
Awesome work @karmatosed and @mapk. Thank you for wrangling it. It should make everything more consistent :) |
Related: #12366.
Some examples of tooltips existing as of today in different places of the block editor:
Some examples of dropdown menus:
When working on #16557 I also noticed this interesting case where the same controls can be displayed in the dropdown or inline:
In both cases, they use the same labels. My proposal is to use the same capitalization in tooltips as we do for labels in dropdown menus to make everything easier.
The text was updated successfully, but these errors were encountered: