Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Background Tools" an easy API and add to Group / Columns #16479

Closed
3 tasks done
Tracked by #33447
mtias opened this issue Jul 9, 2019 · 11 comments
Closed
3 tasks done
Tracked by #33447

Make "Background Tools" an easy API and add to Group / Columns #16479

mtias opened this issue Jul 9, 2019 · 11 comments
Assignees
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Jul 9, 2019

As part of the effort to refine how we present and expose common block functionality (see #15450) we'll be both working on the technical infrastructure and the actual solutions. One of those is background tools. Right now it's possible to add video backgrounds, colored overlays, etc, to the Cover block alone. It'd make sense to extract this and extend to other container blocks (group and columns, for example) as well as expanding the features.

This ticket is meant to focus on the UI for background tools (toolbar and block inspector) and its feature set.

  • Background image.
  • Background video.
  • Color & Overlay.
  • Background gradient.
  • Focus point (if using image).
  • Parallax effect (if using image).

Tasks

@mtias mtias added [Feature] Block API API that allows to express the block paradigm. [Feature] UI Components Impacts or related to the UI component system labels Jul 9, 2019
@mtias mtias added the Needs Design Needs design efforts. label Jul 14, 2019
@karmatosed
Copy link
Member

Just noting a few issues exploring this to feed into a global ticket:

Background tools for columns: #16660
Gradients in cover images: #16662

@strarsis
Copy link
Contributor

When a background image is set as background, it would be nice if also the dominant image color is automatically set as background image. Then the element already got a good color while the image still loads and when images are disabled.

@karmatosed
Copy link
Member

I am going to remove needs design for now from this as both issues linked do have that and are in progress.

@karmatosed karmatosed removed the Needs Design Needs design efforts. label Dec 20, 2019
@mtias mtias mentioned this issue Feb 20, 2020
82 tasks
@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Mar 7, 2020
@ItsJonQ
Copy link

ItsJonQ commented May 22, 2020

When a background image is set as background, it would be nice if also the dominant image color is automatically set as background image. Then the element already got a good color while the image still loads and when images are disabled.

@strarsis I think that's a wonderful idea!!! This suggestion inspired me to experiment and I think I have something pretty solid working <3

Video demo:
https://d.pr/v/f2flil

@caseymilne
Copy link

caseymilne commented Aug 10, 2021

Sorry if it's been already discussed but can the InspectorControls be grouped into a new component that could then be used consistently to provide backgrounds? And in situations where you might need to provide multiple backgrounds for 1 block (custom blocks might) then that component could be utilized again in multiple panels, like:

<BackgroundControlSet for="div" />
<BackgroundControlSet for="div.child" />

Any thoughts about using the same split as Elementor which is to define "Background Overlay" as separate from "Background"?

@apeatling apeatling moved this to Not Started in Design Tools Project Nov 2, 2021
@glendaviesnz glendaviesnz moved this from ⏱ Not Started to ⏳ In Progress in Design Tools Project Jan 20, 2022
@glendaviesnz glendaviesnz self-assigned this Jan 20, 2022
@glendaviesnz
Copy link
Contributor

Have started a discussion here about options for implementing this.

@adamziel
Copy link
Contributor

adamziel commented Apr 1, 2022

@andrewserong since you self-assigned this issue recently: Is there any feature that you think could still land until Wednesday next week to be included in WordPress 6.0 release? To increase visibility, we can add it to the WordPress Editor 6.0 project board.

@andrewserong
Copy link
Contributor

Thanks for the ping @adamziel — I don't think there'll be anything to land in time for 6.0 from what I was exploring. I worked on a proof of concept for a background image block support in #39243 (comment) and we now have designs for a future direction for how the background controls might work (in #39427), but that will likely be a bigger piece of work for post 6.0.

@porg
Copy link

porg commented Jun 13, 2023

As this very ticket deals with the technical foundations for making more sophisticated background options (as of WP 6.2 only available in the Cover block) generally available for various blocks, especially for the Group block, I think this idea is worth sharing here:

@mtias mtias changed the title Background Tools Make "Background Tools" an easy API and add to Group / Columns Aug 2, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 4, 2023
@annezazu
Copy link
Contributor

Wanted to note that this continues to come up around template parts, especially for a simple use case of wanting to have a background image in a header for example: #29238 This issue was closed but feedback was gathered for consideration.

@mtias
Copy link
Member Author

mtias commented Sep 29, 2024

Closing as this is all done.

@mtias mtias closed this as completed Sep 29, 2024
@github-project-automation github-project-automation bot moved this from ⏳ In Progress to ✅ Done in Design Tools Project Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

No branches or pull requests