Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent row selection behaviour #15692

Closed
draganescu opened this issue May 17, 2019 · 3 comments
Closed

Inconsistent row selection behaviour #15692

draganescu opened this issue May 17, 2019 · 3 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] DOM /packages/dom [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

Describe the bug
When I use the keyboard to select one row of text the behaviour in Gutenberg is inconsistent:

  • if the row is NOT the last row, I can press SHIFT + Down Arrow and it will select every letter up to the first line break
  • if the row is the last then pressing SHIFT + Down Arrow I will unwillingly enter block selection bode and will then end up selecting two entire blocks. Exiting this mode is highly unintuitive and without using the mouse I ended up deleting content.

Expected behavior
I expect consistent row selection, and if SHIFT + Down Arrow is intended to be used for block selection then I should have to press it once more after the last row is selected, to signify that my clear intent is to select beyond the current block.

Screenshots

row-selection

@draganescu draganescu added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Needs Accessibility Feedback Need input from accessibility labels May 17, 2019
@afercia afercia added [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] DOM /packages/dom and removed Needs Accessibility Feedback Need input from accessibility labels May 18, 2019
@afercia
Copy link
Contributor

afercia commented May 18, 2019

For a similar, previous, issue see #12322 / #14448.

Text selection with keyboard within a block should replicate the native behavior in a textarea.

The last press of Shift + Down Arrow should select text within a block till the end of the block text.

Similarly when selecting in the opposite direction pressing Shift + Up Arrow.

@draganescu
Copy link
Contributor Author

@ellatrix as Andrea mentioned above I looked at all the other issues but in all fairness it's a bit hard to follow, so the question is:

Is this issue I described here fixed "as good as possible" or, if not, what is the current situation, because all the other issues ( #12322 / #14448 etc. ) are closed as fixed but this still happens.

@ellatrix ellatrix removed the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Jun 27, 2019
@draganescu
Copy link
Contributor Author

This seems to be solved in current master.

arrow-selection

It does look like SHIFT + arrow down works but if you then press SHIFT + arrow up you switch to block selection unexpectedly. But that is another issue, I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] DOM /packages/dom [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants