Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: core/data README is only updated for changes in selectors #15626

Closed
oandregal opened this issue May 14, 2019 · 1 comment · Fixed by #15679
Closed

Documentation: core/data README is only updated for changes in selectors #15626

oandregal opened this issue May 14, 2019 · 1 comment · Fixed by #15679
Assignees
@oandregal
Labels
[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers

Comments

@oandregal
Copy link
Member

How to reproduce:

  • Make a change in the JSDoc of addEntities to be found inpackages/core-data/src/actions.js
  • Make a change in the JSDoc of canUser to be found inpackages/core-data/src/selectors.js
  • Execute npm run docs:build.

Notice how packages/core-data/README.md only reflects the changes in the selectors.js file, while docs/designers-developers/developers/data/data-core.md contains both changes.
@oandregal oandregal added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers labels May 14, 2019
@oandregal oandregal self-assigned this May 14, 2019
This was referenced May 14, 2019
Closed
Merged
@oandregal
Copy link
Member Author

#15679 is attempting to fix this.

@oandregal oandregal mentioned this issue May 16, 2019
Merged
@oandregal oandregal changed the title core/data README is only updated for changes in selectors Documentation: core/data README is only updated for changes in selectors May 16, 2019
oandregal pushed a commit that referenced this issue May 16, 2019
@nosolosw
Fixes update-readme script (#15679)
ed630e8 
This PR does two things:

- Fixes #15626 and #15680 by making the script synchronous. In #15200 we missed the fact that to fill tokens within the same file we need to execute docgen synchronously, otherwise, the last token process will overwrite the first.

- Updates our espree dependency to 4.0.0. When error reporting was back, we uncovered that introducing short Fragment syntax in #15120 caused docgen to fail. The reason is that the espree version we used didn't support that. This fixes it by upgrading it to one that does. A couple of restrictions:

    - espree uses acorn-jsx to power JSX parsing.
    - [email protected] added support for JSX fragment short syntax (patched in 4.1.1).
    - [email protected] added [email protected]. We should use this at a minimum.
    - [email protected] added acorn@6 and acorn-jsx@5 for parsing. This caused an error I couldn't identify the source.
    - [email protected] removed support for the attachComment. We use this for collocating the JSDoc comment with the proper export statement. Without this, we can't migrate to [email protected].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oandregal oandregal

Labels
[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes update-readme script WordPress/gutenberg
1 participant
@oandregal