Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider new icons for "Group" and "Ungroup" #15602

Closed
kjellr opened this issue May 13, 2019 · 14 comments · Fixed by #16001
Closed

Consider new icons for "Group" and "Ungroup" #15602

kjellr opened this issue May 13, 2019 · 14 comments · Fixed by #16001
Assignees
Labels
[Block] Group Affects the Group Block [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented May 13, 2019

When the Group block was originally introduced, it was positioned as a "Container" or "Section" block. The icon was designed to represent that idea:

Frame 3

Since merge, the block has been renamed to "Group", and work is in progress (#14908) to add group and ungroup actions alongside it. With this new framing, we should reassess whether or not the current icon best represents the block's functionality.

For #14908, some initial thought was put into the icons for those actions, and the question was raised whether or not the actual block icon should be revised to match. Since decisions around those icons aren't essential to getting the functionality merged in, I wanted to break this out into a separate thread for discussion.

Oddly enough, Material doesn't include icons for Group and Ungroup. The draft icons used in #14908 are custom ones:

Frame 5

These are loosely based on the closest thing we have to icons for "single/group" right now: The image and gallery icon:

Frame 6

The "Group" icon is structured similarly to the Gallery icon, but the "Ungroup" one is a little more specific, showing two entirely separate cards being pulled apart.

A quick glance at the icons used in other applications shows this "layered vs. apart" treatment is fairly common:

55973946-9a76dc80-5c54-11e9-9600-5e221d168f09

55973947-9a76dc80-5c54-11e9-9bac-2419ae696800

_(Keynote, Sketch)_

Those examples also show a selection outline. It may make some sense to try adding that here too.

I'm dumping all my other explorations below for reference:

Screen Shot 2019-05-13 at 10 08 52 AM

As noted in the other thread, versions 1, 2, and 7 are my favorites for now. @melchoyce liked 2, along with 9 and 10. @mapk felt that 8 best represented the actions.

Any further ideas/reactions are greatly appreciated!

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Group Affects the Group Block labels May 13, 2019
@kjellr kjellr self-assigned this May 13, 2019
@mtias
Copy link
Member

mtias commented May 14, 2019

1 and 2 seem the clearest and most straightforward to me. 9, 10, 11 feel like they could be used for other layout tools (rows / columns).

@melchoyce
Copy link
Contributor

Also just saw these icons:

image

@kjellr
Copy link
Contributor Author

kjellr commented May 15, 2019

We actually use (the outline version of) that layers one for the individual column block. 😄

Screen Shot 2019-05-15 at 7 45 10 AM

@mapk
Copy link
Contributor

mapk commented May 15, 2019

I really like the "grouped" version of the icon to include an outline, but I think the box style shown above isn't great. I do like the examples where the box outline has nodes in the corners.

I lean toward 8 or 5 because any overlapping icons tend to communicate a grouped item to me. If we can modify the outline in 8 like below, I think that might help. This is pretty rough just for conversations.

icons

Even 7 above feels pretty good too!

@kjellr
Copy link
Contributor Author

kjellr commented May 15, 2019

If we can modify the outline in 8 like below, I think that might help.

Unfortunately, I haven't been able to make something like this this work given the constraints of the pixel canvas, and the size and line weight requirements of Material Icons.

The closest I can get is something like these, and I think they're a little fiddly and weird looking.

Screen Shot 2019-05-15 at 2 35 40 PM

Screen Shot 2019-05-15 at 2 36 11 PM

--

It seems like we're pretty all over the place. 😄 The most-liked one from above has been number 2, but @mapk disliked that it reminded him of pathfinder tools in Illustrator (which is totally valid and true, but perhaps not a universal issue):

Screen Shot 2019-05-15 at 2 40 36 PM

The more I stare at it, the more I'm not sure it's right.

@drw158, do you have any thoughts for this one?

@jemlovestodraw
Copy link

I like option 8 above. For me, the box around the grouped items makes the distinction between grouped and un-grouped much clearer. Could be worth a look at Font Awesome for inspiration:
Group https://fontawesome.com/icons/object-group?style=regular
Ungroup https://fontawesome.com/icons/object-ungroup?style=regular
But I'm not a fan of the fiddly transform control boxes on the corners of those.

@strarsis
Copy link
Contributor

+1! Being able to group a large number of selected blocks into a new group block would be really helfpul.

@mapk
Copy link
Contributor

mapk commented May 24, 2019

Similar to number 8 above, how does this look?

Screen Shot 2019-05-24 at 3 47 39 PM

Screen Shot 2019-05-24 at 3 48 17 PM

@kjellr
Copy link
Contributor Author

kjellr commented May 27, 2019

@mapk I find the shape in the Group version of that just a little awkward, personally. Here are a few more variations on that:

Screen Shot 2019-05-27 at 9 04 53 AM

All of these use the handles from Material's format-shapes icon, which seems like a reasonable example to stick to. I like version 8D the best.

(Also, I tried having the blocks stacked vertically, which would be more common in Gutenberg, but I felt that it read too much like a B).

@mapk
Copy link
Contributor

mapk commented May 28, 2019

The handles from Material look good. Nice touch! I actually liked the stacked items in the shape of the B because of your relation to actual Gutenberg blocks. I removed the radius and kept it staggered. What do you think, @kjellr? Without all the rounded corners, I think it feels a lot better.

Screen Shot 2019-05-28 at 1 24 15 PM

Screen Shot 2019-05-28 at 1 21 16 PM

If that still doesn't sit well, let's go with 8D from your mockups.

@kjellr
Copy link
Contributor Author

kjellr commented May 29, 2019

I made a slight adjustment to include a bit of a rounded corner on the interior blocks:

Screen Shot 2019-05-29 at 9 34 38 AM

Then I tried it out in context. I'm not particularly happy with it, personally. The handles look much too blocky — almost like it's a pixellated illustration of what we're going for:

Screen Shot 2019-05-29 at 9 45 41 AM

Screen Shot 2019-05-29 at 9 46 10 AM

Screen Shot 2019-05-29 at 9 45 54 AM

I think straying from the Material example for those handles may be in our best interest after all. Something like this might work, but I need to double check when I'm on a non-retina screen later today (Since those handles are just 1px larger than the borders, I'm worried they may be blurry on some screens):

Screen Shot 2019-05-29 at 10 03 58 AM

Screen Shot 2019-05-29 at 10 04 32 AM

Screen Shot 2019-05-29 at 10 04 22 AM

@kjellr
Copy link
Contributor Author

kjellr commented May 29, 2019

Something like this might work, but I need to double check when I'm on a non-retina screen later today (Since those handles are just 1px larger than the borders, I'm worried they may be blurry on some screens):

Actually — looking at this on a non-retina screen, it's totally fine. 😄 So I think we're ok.

My only remaining concern is that "Ungroup" doesn't really make much sense when it appears on its own. Does anyone have any thoughts or ideas about that?

Thanks!

@melchoyce
Copy link
Contributor

Maybe "Ungroup Blocks" would make it a tiny bit more clear?

@kjellr
Copy link
Contributor Author

kjellr commented May 31, 2019

It sounds like we're feeling good about that last set of icons, possibly with the added "Blocks" label in the ellipsis menu item. I'll keep an eye on #14908 and create a PR for this after that's merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants