-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<aside> more appropriate than <figure> for wrapping Pull Quote #14606
Comments
Looks like this was already discussed and abandoned here #9599 |
Not sure it does in the definition of the Instead, there's one example of blockquote within an aside in the @m-e-h the point you raised is valid, but only in one specific case. The bit you quoted from the figure element documentation makes it clear:
Theoretically, there should be a way to distinguish when a quote is or isn't part of the main content. Regardless, there's an important consequence to consider. The See also #9599 (comment) |
Sorry for the duplicate. I should've searched a little better. I came across that W3C recommendation while researching something unrelated and wanted to open an issue here before I forgot. I do think that Wouldn't something that is
be considered a main region of a page? You do make an excellent point, though, @afercia and it leads me to think
When choosing between a Quote and a Pull Quote, I sometimes just select the first one I see or whichever is styled the way I want. I'm assuming the typical user might do the same thing. Probably best to stick to what we currently have. I'm thinking we should close this issue since it was already discussed in #9599 . Any reason to leave it open? |
Kept open to be fair and and allow you to reply :) Closing now, if no objections. |
I realize this is closed but... It would seem to me is less appropriate than . That said, if as @afercia mentions aside is a ARIA landmark then I would think it could be . For all intents and purposes, a blockquote is a decorative image, and decorative images are supposed to be tagged so AT ignores them. That is, a blockquote is more for visual aesthetics than actually adding content value, as the content has already been - or will be - presented on the page in a paragraph or perhaps a list.In short, I would think it's rare that AT needs to be aware of a blockquote; in the same way AT doesn't need to be aware of decorative images. |
Describe the bug
Currently the PullQuote block outputs this HTML:
The HTML5 specifications suggest it should look something like this instead:
The W3C docs for the figure element have this to say:
The text was updated successfully, but these errors were encountered: