Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar appears when shift is pressed in Safari on macOS #1349

Closed
markjaquith opened this issue Jun 21, 2017 · 2 comments · Fixed by #1365
Closed

Toolbar appears when shift is pressed in Safari on macOS #1349

markjaquith opened this issue Jun 21, 2017 · 2 comments · Fixed by #1365
Assignees
@youknowriad
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Milestone
Beta 2

Comments

@markjaquith
Copy link
Member

Safari 10.1.1 (current latest stable) on macOS. master branch at c67326c.

Every time the shift key is pressed, the toolbar appears. So... every time you go to capitalize a letter, the toolbar is flickering (#1300) in and out.
@GaryJones
Copy link
Member

Confirmed - I can replicate this. It actually seems to be any modifier key - cmd, alt, and ctrl also bring up the toolbar, until the next non-modifier key is pressed.

@mtias mtias added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended labels Jun 22, 2017
@mtias
Copy link
Member

mtias commented Jun 22, 2017

@youknowriad mind looking at this one? Sounds related to when we did 1b0b7ff

@mtias mtias added this to the Beta 2 milestone Jun 22, 2017
@youknowriad youknowriad self-assigned this Jun 22, 2017
@youknowriad youknowriad mentioned this issue Jun 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Beta 2
Development

Successfully merging a pull request may close this issue.

Blocks: Don't show the block toolbar if we press ctrl, shift... on Safari WordPress/gutenberg
4 participants
@GaryJones @youknowriad @markjaquith @mtias