Editor: Update withDispatch-wrapped components to use registry if applicable

[aduth]

Previously: #11851

With the changes introduced by #11851, we should seek to refactor components which provide data through withSelect for the sole purpose of satisfying a dispatch callback. These components instead should use the new registry argument.

Upon investigation, these are the components I discovered to be refactored:

• EditorGlobalKeyboardShortcuts (the isDirty prop) (Use select in withDispatch to avoid using unused props #13288)
• InserterMenu (the selectedBlock prop) (Use select in withDispatch to avoid using unused props #13288)
• EditorModeKeyboardShortcuts (the hasBlockSelection prop) (Use select in withDispatch to avoid using unused props #13288)
• BlockConvertButton (the block prop) (Performance: optimize the usage of getBlockIndex #13067)
  • Refactor: block is used in withSelect, but it should be refactored to use the trivial getBlockName selector instead (getBlock is deemed expensive)

The workflow for discovering these was to search the codebase for and sort through results of withDispatch with a mapping which makes use of the second ownProps argument.

Searching 1670 files for "withDispatch( ( dispatch, ownProps )"

[gziolo]

Did you search for withDispatch( ( dispatch, There are 37 matches which we might want to verify, too:

[aduth]

I did not! The in-place destructuring could certainly qualify. Let's update the original comment with new items as they're discovered.

[aduth]

I updated the original comment with two more from a withDispatch( ( dispatch, { search.

[aduth]

Closing based on referenced subtasks having been merged.