Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable block not editable #12596

Closed
hellerbenjamin opened this issue Dec 4, 2018 · 3 comments · Fixed by #14367
Closed

Reusable block not editable #12596

hellerbenjamin opened this issue Dec 4, 2018 · 3 comments · Fixed by #14367
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Milestone

Comments

@hellerbenjamin
Copy link

Describe the bug
When editing a reusable block from a page or post, adding new blocks is impossible because the menu that pops up quickly closes and focus shifts back to the reusable block title.

To Reproduce
Steps to reproduce the behavior:

  1. Create reusable block
  2. Insert reusable block on page or post
  3. Click the edit button next to reusable block's name.
  4. Attempt to add a block inside the reusable block using the plus button.

Expected behavior
The menu should stay open until a block is selected.

Screenshots
Here is a screencast showing the issue: https://www.dropbox.com/s/7o33s00o6k1qlrc/gutenberg-reusable-issue.mp4?dl=0

Desktop (please complete the following information):
Linux Mint 18.3
Firefox 63, also happens in Chrome.

Smartphone (please complete the following information):
Not tested

Additional context
Gutenberg 4.6.1
WP 4.9.8 vanilla install 2017 theme.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Testing Needs further testing to be confirmed. labels Dec 4, 2018
@mapk
Copy link
Contributor

mapk commented Jan 5, 2019

I tested with a similar result. The block inserter would close fairly quickly. There were a couple times that I would click another block, but the other block would not be inserted.

My experience:

reusable-inserter

@mapk mapk added this to the Future: Phase 2 milestone Jan 5, 2019
@strarsis
Copy link
Contributor

I can use the edit button for editing the name/title of that reusable block,
the content is not editable. It would be nice if it could be editable in place.

@steph-inners
Copy link

My current workaround for this is to use the / to select the block instead of the plus button. It seems to be consistent in letting me add new blocks that way.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Testing Needs further testing to be confirmed. labels May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants