Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text block: Failures when using shift+enter for adding line breaks #1243

Closed
westonruter opened this issue Jun 19, 2017 · 1 comment · Fixed by #1299
Closed

Text block: Failures when using shift+enter for adding line breaks #1243

westonruter opened this issue Jun 19, 2017 · 1 comment · Fixed by #1299
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@westonruter
Copy link
Member

westonruter commented Jun 19, 2017

TinyMCE in WordPress presently requires that you use shift+enter to add a single line as opposed to adding a paragraph. Having this engrained into my muscle memory (though I realize a simple enter creates a single line break now, I was trying the same in the Text block only to encounter a couple issues:

  1. When typing First<shift+enter>second<shift+enter>third there are three lines appearing in the block as expected, but the up arrow only allows me to to go up to the second line; it does not allow be to go up to the first line.

  2. When switching to the Text tab, every line other than the first is lost:

<!-- wp:core/text -->
<p>First</p>
<!-- /wp:core/text -->
@westonruter westonruter added [Feature] Blocks Overall functionality of blocks [Component] TinyMCE [Type] Bug An existing feature does not function as intended labels Jun 19, 2017
@youknowriad
Copy link
Contributor

youknowriad commented Jun 19, 2017

The current text block is meant to contain only a single p. We probably should catch shift+enter and avoid creating new ps

Edit: An alternative would be to break out of the block and create another text block if we click shift+enter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants